After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343615 - [alsamixer] implement read-only / write-only / no-record / no-mute flags
[alsamixer] implement read-only / write-only / no-record / no-mute flags
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.x
Other Linux
: Normal enhancement
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-01 17:07 UTC by Josselin Mouette
Modified: 2012-10-02 22:45 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
patch adding readonly/writeonly flags to GstMixerTrack (685 bytes, patch)
2007-01-08 12:55 UTC, Tim-Philipp Müller
committed Details | Review

Description Josselin Mouette 2006-06-01 17:07:22 UTC
[ forwarded from http://bugs.debian.org/369667 ]

A bunch of alsa mixer elements are made read-only because they only reflect
hardware status, yet gnome-volume-control allows clicking on them and even
changes the item, even though it can't actually be changed by the user.
Comment 1 Ronald Bultje 2007-01-06 20:26:24 UTC
-> gst, they should implement flags for this, so we can read that flag and set the control insensitive based on the flag value.
Comment 2 Tim-Philipp Müller 2007-01-07 22:05:03 UTC
I suppose this is covered by bug #347557 then.

Ronald, do you have a particular API in mind for this by any chance? (e.g do you just want getter/setters of pre-defined flags or freeform/string-based getters/setters or something completely different?)


*** This bug has been marked as a duplicate of 347557 ***
Comment 3 Ronald Bultje 2007-01-07 22:45:05 UTC
just a flag in the GstMixerTrack (e.g. readable/writable) would be enough. If you want to be strict about api compat, just call it read-only and write-only (where 0 = readwrite).

I don't think this is a dup of the other report. For the other report, I would prefer to make it a GstMixerOptionsTrack (the one that only alsa uses right now). The mixer should then display this options-track in the same tab as the volume control itself (either hardcoded or as a user preference). that way, the other report needs no new API. Introducing things like a mic-flag and a line-flag and such is really not the right thing, imo. There is a similar report in gnome-media, and this is how I proposed to fix it. I think Brian thought it was an acceptable approach, also.
Comment 4 Tim-Philipp Müller 2007-01-08 12:55:19 UTC
Created attachment 79743 [details] [review]
patch adding readonly/writeonly flags to GstMixerTrack

Like this you mean?
Comment 5 Ronald Bultje 2007-01-08 13:27:28 UTC
Yes, baiscally. And then implement the read-only flags in alsa.
Comment 6 Tim-Philipp Müller 2007-01-08 15:02:40 UTC
Can't find any obvious way to get this info from alsa - care to make a patch or point me in the right direction?
Comment 7 Marc-Andre Lureau 2008-03-17 23:49:44 UTC
There is snd_ctl_elem_info_is_writable, that could help.
Comment 8 Sebastian Dröge (slomo) 2009-05-07 11:19:09 UTC
Tim, is there anything blocking this patch from being committed after freeze? The alsa/etc parts could still be done later and don't look to complicated either ;)
Comment 9 Sebastian Dröge (slomo) 2009-09-10 08:53:30 UTC
So this should be committed... and later alsa and friends can be updated to use the flags.
Comment 10 Tim-Philipp Müller 2009-09-11 09:23:48 UTC
Done:

 commit 794e03640d8db298a65f2ba466eeca93c3491521
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Fri Sep 11 10:16:15 2009 +0100

    mixertrack: add READONLY and WRITEONLY flags
    
    Should really have been READABLE and WRITABLE, but those are hard to
    add whilst maintaining backwards compatibility. See #343615.
    
    API: GST_MIXER_TRACK_READONLY
    API: GST_MIXER_TRACK_WRITEONLY



Now the alsa mixer just needs to implement them. And when we do that, we could implement the no-record/no-mute flags too.
Comment 11 Tim-Philipp Müller 2012-10-02 22:45:01 UTC
GstMixer is no more, so let's close this.