After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343505 - Make Search ignore accents
Make Search ignore accents
Status: RESOLVED OBSOLETE
Product: evolution
Classification: Applications
Component: general
2.24.x (obsolete)
Other All
: Normal enhancement
: Future
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
: 605271 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-05-31 13:49 UTC by René Brandenburger
Modified: 2021-05-19 11:45 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
proposed eds patch (8.89 KB, patch)
2009-04-17 11:57 UTC, Milan Crha
committed Details | Review

Description René Brandenburger 2006-05-31 13:49:53 UTC
quick-search bar should ignore accenst on letters. So á à .... all should be considered equal to a.
Motivation is that you often get contact information containing accents you can't enter without using the charactermap

Other information:
Comment 1 André Klapper 2006-05-31 16:05:25 UTC
which component do you refer to? mailer, contacts, calendar, all?
anyway, this is an enhancement.
Comment 2 René Brandenburger 2006-05-31 16:27:19 UTC
best is to have this consistent throughout the application
Comment 3 Harish Krishnaswamy 2006-06-05 12:29:43 UTC
Reassigning to Srini and setting target to Future.
Comment 4 André Klapper 2009-02-02 23:21:44 UTC
Banshee has C# code for this, see bug 458941.
For me fixing this would still be the killer. Makes searching for messages so much easier in language with lots of accents. Hence CC'ing mcrha. ;-)


On Mon, Feb 25, 2008 at 12:42 PM, Gabriel Burt <gabriel.burt@gmail.com> wrote:
    Search in stable was implemented as a C# loop iterating over all the
    TrackInfo objects in a Source (eg Library, Playlist, etc) and doing
    string comparisons - the code is here:
   
http://svn.gnome.org/viewvc/banshee/branches/banshee/stable/src/Core/Banshee/PlayerInterface.cs?revision=3124&view=markup
    - see OnSimpleSearch and DoesTrackMatchSearch.  What allows it to
    ignore accents etc is the use of
    CultureInfo.CurrentCulture.CompareInfo.Compare in
    src/Core/Banshee.Base/StringUtils.cs.

    However, in trunk search has been completely rewritten.  It is parsed
    and turned into SQL using src/Libraries/Hyena/Hyena.Query.  So, we
    don't have the advantages of the CultureInfo library.  What we really
    need is a custom sqlite function for doing both case-insensitive
    matching (currently only works for ASCII chars) and for accent-less
    matching.  Should probably google some more since it's quite likely
    others have solved this for sqlite already.  If not, I would suggest
    either looking into making a C/C++ function for sqlite, or see if it
    can be done efficiently enough in C# -
   
http://anonsvn.mono-project.com/viewcvs/trunk/mcs/class/Mono.Data.Sqlite/Mono.Data.Sqlite_2.0/
    - SQLiteFunction.cs
Comment 5 Milan Crha 2009-02-03 12:24:57 UTC
I do not know. When I imagine an LDAP server query, to fetch all the contacts to manually check value there, instead of just passing some text to the server doing all the bad work for us. Same for calendar items and messages.
Comment 6 Milan Crha 2009-04-17 11:57:50 UTC
Created attachment 132821 [details] [review]
proposed eds patch

for evolution-data-server;

In contacts only, for those supporting summary searches, in local cache mainly, as the first step, to show someone more interested in this area one possible way. Nonetheless, the "remove accents" function should be more tweaked, as it works fine for my language, but for some other might not.

Note: it's safe to return pointer to already freed string in compare helper functions, as the result is only checked for NULL/not-NULL values, not for its content.
Comment 7 Srinivasa Ragavan 2009-04-20 08:21:12 UTC
Looks fine to me.
Comment 8 Milan Crha 2009-04-24 16:31:15 UTC
Created commit 98a0731 in master.

Letting bug opened in case someone is interested to include this also in any other area in evo/eds/...
Comment 9 André Klapper 2009-12-29 12:08:38 UTC
*** Bug 605271 has been marked as a duplicate of this bug. ***
Comment 10 André Klapper 2021-05-19 11:45:17 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. 
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org (resources are unfortunately quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/Community/GettingInTouch/BugReportingGuidelines
and create a new enhancement request ticket at
  https://gitlab.gnome.org/GNOME/evolution/-/issues/

Thank you for your understanding and your help.