After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342670 - folder size should update in realtime
folder size should update in realtime
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File Properties Dialog
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-23 08:27 UTC by Fabio Bonelli
Modified: 2012-08-31 20:45 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Update directory size in properties when it changes (874 bytes, patch)
2012-08-31 15:14 UTC, William Jon McCann
committed Details | Review

Description Fabio Bonelli 2006-05-23 08:27:10 UTC
When you click on "Properties" you get the size of that file or folder, but If you are writing to it, the size doesn't update.

It would be nice if the size shown would always reflect the current size.
Comment 1 Teppo Turtiainen 2007-01-20 17:06:23 UTC
Works perfectly for me with Nautilus 2.16.1 on Ubuntu Edgy and I use this feature frequently. Can you make sure you have Gamin [1] installed and that it is working properly?

[1] http://www.gnome.org/~veillard/gamin/
Comment 2 Fabio Bonelli 2007-02-06 20:57:38 UTC
Using Feisty here, with Nautilus 2.17.90. gamin works as it should. Note that the size updates with files, but doesn't with directories.

$ wget --mirror www.gnome.org
and look at the properties for ~/www.gnome.org/
Comment 3 Teppo Turtiainen 2007-02-07 06:23:27 UTC
Yes, it doesn't seem to work with folders. I can't test with 2.17.90 right now, but I'll take your word for it. Confirming.
Comment 4 A. Walton 2009-01-05 01:51:04 UTC
Does this bug still exist in Nautilus as of the GIO refactoring?
Comment 5 Teppo Turtiainen 2009-01-05 05:41:02 UTC
Yes, it's the same as before in Nautilus 2.24.1. Works with files but not with folders.
Comment 6 William Jon McCann 2012-08-31 15:14:14 UTC
Created attachment 223073 [details] [review]
Update directory size in properties when it changes
Comment 7 Cosimo Cecchi 2012-08-31 15:47:05 UTC
Review of attachment 223073 [details] [review]:

::: src/nautilus-properties-window.c
@@ +971,3 @@
 		}
+		if (changed_file != NULL) {
+			nautilus_file_recompute_deep_counts (changed_file);

I think this should go into the if (dirty_target) block below, since that's where we update all the other value fields from.
Comment 8 William Jon McCann 2012-08-31 16:39:11 UTC
Review of attachment 223073 [details] [review]:

::: src/nautilus-properties-window.c
@@ +971,3 @@
 		}
+		if (changed_file != NULL) {
+			nautilus_file_recompute_deep_counts (changed_file);

And iterate over the files again? Not sure what the benefit is to be honest.
Comment 9 Cosimo Cecchi 2012-08-31 17:11:32 UTC
Review of attachment 223073 [details] [review]:

Yeah I was missing the fact that changed_file is just an iter over a list. Makes sense then.