GNOME Bugzilla – Bug 342482
store datetime of when image was imported
Last modified: 2007-12-10 11:38:59 UTC
Storing DateTime of when image was imported would greatly reduce complexity of 'show images by import time' -patch, which in itself would greatly ease task of tagging images (since images imported at same time are more likely to belong into same categories/tags). Possible implementations are: - direct field to Photo, DATETIME, 8bytes/field. - separate indexing table ImportTime(@id, DateTime) and PhotoImported(@id->ImportTime(id), @photo->Photo(id))
Bug #321770 (Auto Tag imported photos with special tag) is greatly depending on the solution for this bug. Makes it very easy to tag the latest photos. photostore.cs stores all fields in photos into cache. ===>>> 1) This would indicate that using two tables. * imports (ID (importid), DATETIME (datetime for import)) * photos (.... , importid (uid)) Would be a good idea. Also good from standard database design, with no duplicated information. Makes it a bit difficult to search and filter based upon the import time though. ===>>> 2) Then, again, memory is cheap so the following is much easier and perhaps better. * photos (...., DATETIME (datetime for import)) Storing datetime direct into Photos, would make filtering much easier. If no-one objects I can work on the first solution (since I want to fix the "Last Imports" filter), that is implementing this with two different tables.
Created attachment 66236 [details] [review] Small patch Here is a small patch to store an Import Id with every photo (it changes the database, so ensure you have a good backup first). This import id referes to the Imports database which contains the time this import batch was run. Please review and comment. I'm not sure this solution will be the final one though. Perhaps it is enough to only store the last 15 imports, and keep them separate from photos. See bug #321770 – Auto Tag imported photos with special tag
Should be fairly easy to merge this patch with the gui part in bug #321770 Do we really need to keep the imported session time for ALL photos in F-Spot?
I have now merged this request with bug #321770 which is about filtering on last import rolls. Added one extra field to photos, which referes to Imports table. The Imports table contains a DateTime time stamp. Can we close this one, or leave it open until the other one has been accepted?
Do we still need this, since the introduction of import rolls? It's not exactly the same but should be fitting, isn't it?
I Agree. Vote to close it.