GNOME Bugzilla – Bug 342330
Fix tag writing to use new semantics for id3v2mux and id3mux
Last modified: 2006-06-19 13:11:01 UTC
Bug #339918 changed the GstTagInterface merge-mode semantics for the id3v2mux and id3mux plugins. CVS rhythmbox need to be updated to use the new interface for gst-plugins-ugly > 0.10.3 and use the old interface for 0.10.2 <= gst-plugins-ugly <= 0.10.3. That way rhythmbox CVS and >= 0.9.5 will always Do the Right Thing regardless of the installed gst-plugins-ugly. The existing rhythmbox in CVS (and 0.9.4 and 0.9.4.1) checks for a minimum version of id3mux, not for a specific version of id3mux. The only potential problems will be with 0.9.4 and 0.9.4.1. <= 0.9.3 isn't a problem because tag writing wasn't ever enabled with gstreamer 0.10. The only thing we can do there is add a FAQ saying which versions of -ugly work with which version of rhythmbox.
This change: 2006-06-02 James Livingston <doclivingston@gmail.com> * metadata/rb-metadata-gst.c: (rb_gst_plugin_greater), (rb_add_id3_tagger), (rb_metadata_init): add support for using id3v2mux, and check whether we are using a version of id3mux that has the correct merge-mode behaviour. implements most of this behaviour, except that it doesn't check for id3v2mux > 0.10.3, because the interface change for idv2mux (taglib based mux) was done after 0.10.3 was released. Have tested it otherwise, and seems to be working OK.
I thought that it got renames to id3v2mux after 0.10.3 so the check wasn't needed, but I'm wrong. Fixed in cvs.