After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342281 - String Change For Condition Of Highlighted Read-Only Calendar Source
String Change For Condition Of Highlighted Read-Only Calendar Source
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.8.x (obsolete)
Other All
: Normal trivial
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-05-18 18:37 UTC by David Richards
Modified: 2013-09-13 00:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for string change for condition of highlighted read only calendar source.. (993 bytes, patch)
2006-06-21 05:50 UTC, Raghavendran
rejected Details | Review
Patch with corrections made for string change for condition of highlighted read only calendar source.. (988 bytes, patch)
2006-06-23 10:18 UTC, Raghavendran
committed Details | Review

Description David Richards 2006-05-18 18:37:20 UTC
We are getting a very high number of calls from people that have highlighted a
read-only calendar source and then click "New" to add an appointment on another
calendar.  Evo currently just tells them they are on a read-only source.

String should say something like:
"You have a read-only calendar source selected.  Change to Calendar View and
highlight the calendar you wish to add this appointment".

[ An even better fix would be just to pick another source for them. Perhaps use
the following hunt order:  GroupWise, Exchange and then Local]

Other information:
Comment 1 Raghavendran 2006-06-21 05:50:20 UTC
Created attachment 67767 [details] [review]
Patch for string change for condition of  highlighted read only calendar source..
Comment 2 André Klapper 2006-06-22 12:48:13 UTC
raghavendran:
3 things are wrong with your patch. please take a look again at calendar.error.xml and then a look at your patch again with regard to punctuation and correct spelling.

-  <_secondary>The calendar you have selected is read-only</_secondary>
+  <_secondary>You have a read-only calendar source selected.Change to Calendar View and
+highlight the calendar you wish to add this appointment</_secondary>

1) after a full stop, there must be a whitespace.
2) every <_secondary> string in the file you patch ends with a fullstop. your <_secondary> string does not.
3) please make the string only one line without a linebreak, like the old string. your patch would add a second line (that's why you see two "+" at the beginning of the lines).

please work precise and take care of stuff like that... perhaps it seems kind of nitpicking, but we have to provide a consistent user interface, and this also includes string formatting.
Comment 3 André Klapper 2006-06-22 12:50:08 UTC
4) shouldnt it be "highlight the calendar you wish to add this appointment **TO**"?
Comment 4 David Richards 2006-06-22 12:55:37 UTC
Sentences cannot end with a preposition. :)

How about:
"You have a read-only calendar source selected.  Change to Calendar View and
highlight a calendar that can accept appointments".
Comment 5 André Klapper 2006-06-22 13:24:39 UTC
dave: so "this is the sort of english up with which i cannot put”, heh?
but since gnome is in en_US it could be that you're right. at least i was correct in en_GB. ;-)
Comment 6 David Richards 2006-06-22 13:30:41 UTC
:)  Spoken US English has prepositions at the end of sentences all the time.  I just remember getting hammered in school concerning prepositions. :P  You can alter it as you wish to express the core thoughts.  We are getting a lot of support calls from people getting this dialog.  They click into webcals to check and uncheck them and then forget to change the highlight.
Comment 7 Raghavendran 2006-06-23 10:18:43 UTC
Created attachment 67889 [details] [review]
Patch with corrections made for string change for condition of  highlighted read only calendar source..
Comment 8 Srinivasa Ragavan 2006-07-21 10:45:52 UTC
looks fine to commit. Please send a mail to gnome-i18n-list about the string change.
Comment 9 André Klapper 2006-07-21 10:54:53 UTC
committed patch to CVS HEAD:
http://cvs.gnome.org/viewcvs/evolution/calendar/calendar.error.xml?r1=1.18&r2=1.19

fix will be included in evolution 2.7.90.
patch cannot be committed to stable branch as it includes string changes.

going to send an announcement to gnome-i18n mailing list about this.

closing as fixed.