After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342247 - cleanup: get rid of eel_gtk_signal_connect_free_data
cleanup: get rid of eel_gtk_signal_connect_free_data
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
2.13.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-18 13:12 UTC by Paolo Borelli
Modified: 2006-05-24 13:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (4.13 KB, patch)
2006-05-18 13:13 UTC, Paolo Borelli
committed Details | Review
eel patch (3.10 KB, patch)
2006-05-18 13:19 UTC, Paolo Borelli
committed Details | Review

Description Paolo Borelli 2006-05-18 13:12:42 UTC
el_gtk_signal_connect_free_data is a leftover from the gtk 1.2. days, as the gtk_signal in the names highlights.

GObject has an equivalent function: g_signal_connect_data
Comment 1 Paolo Borelli 2006-05-18 13:13:56 UTC
Created attachment 65765 [details] [review]
patch

the attached patch replaces the eel_gtk_signal function with its gobject equivalent.
Comment 2 Paolo Borelli 2006-05-18 13:19:01 UTC
Created attachment 65767 [details] [review]
eel patch

once the above patch is committed, we can get rid of the helpers from eel
Comment 3 Alexander Larsson 2006-05-24 13:28:50 UTC
Looks good. Please commit both patches.
Comment 4 Paolo Borelli 2006-05-24 13:41:17 UTC
done.