After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342079 - pangoatsui-private.h missing from release
pangoatsui-private.h missing from release
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
1.13.x
Other Mac OS
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2006-05-17 04:52 UTC by Eric Butler
Modified: 2006-05-17 15:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Eric Butler 2006-05-17 04:52:51 UTC 
Hi, it seems that "pangoatsui-private.h" was not included in the pango-1.13.1 release tarball, preventing it from building on OSX. This file is present in the CVS tag for this release, but is not mentioned anywhere in the Makefile.am.

Thanks.
Comment 1 C.J. Collier 2006-05-17 04:57:00 UTC 
Confirmed error.  I will commit this patch if nobody finds a problem with it in the next 24 hours.

cjcollier@norseth:~/src/gnome/pango-1.13.1$ diff -u pango/Makefile.am.orig pango/Makefile.am
--- pango/Makefile.am.orig      2006-05-16 21:53:58.000000000 -0700
+++ pango/Makefile.am   2006-05-16 21:54:09.000000000 -0700
@@ -416,6 +416,7 @@
 pango_querymodules_LDADD += libpango-$(PANGO_API_VERSION).la $(GLIB_LIBS)

 EXTRA_DIST =                                   \
+       pangoatsui-private.h                    \
        pango-enum-types.h                      \
        module-defs.h                           \
        module-defs-fc.c.win32                  \
Comment 2 Behdad Esfahbod 2006-05-17 05:26:15 UTC 
No C.J., please never commit patches to modules that you don't have explicit permission to commit to.
Comment 3 Behdad Esfahbod 2006-05-17 06:14:10 UTC 
2006-05-17  Behdad Esfahbod  <behdad@gnome.org>

        Bug 342079 – pangoatsui-private.h missing from release

        * pango/Makefile.am (libpangocairo_1_0_la_SOURCES):
        Include pangoatsui-private.h.
Comment 4 C.J. Collier 2006-05-17 15:47:19 UTC 
Thanks Behdad.  ACK that request.  Didn't mean to step on anybody's toes.