After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341931 - some error messages not marked for localization
some error messages not marked for localization
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
2.2.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks: 236276 Persian
 
 
Reported: 2006-05-16 02:38 UTC by Roozbeh Pournader
Modified: 2006-07-19 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch against head to fix the problem, only tested on 2.2.3 (1.90 KB, patch)
2006-05-16 02:42 UTC, Roozbeh Pournader 		committed Details | Review

Description Roozbeh Pournader 2006-05-16 02:38:41 UTC 
In evolution's addressbook/gui/contact-editor/e-contact-editor.c, some messages are not marked for translation.

The bug still exists in HEAD. Will attach a patch.

FarsiWeb's internal reference:
farsiweb #562, evolution-translation-is-empty.patch, reported by Araz Sarbar, patch by Roozbeh Pournader
Comment 1 Roozbeh Pournader 2006-05-16 02:42:05 UTC 
Created attachment 65567 [details] [review]
Patch against head to fix the problem, only tested on 2.2.3

The attached patch fixed the problem for the messages that are displayed on the GUI.
Comment 2 André Klapper 2006-05-16 09:42:16 UTC 
confirming. let's get this in for 2.6; however we must inform the mailing lists about this.
Comment 3 Sushma Rai 2006-05-17 09:19:28 UTC 
looks fine, please commit to HEAD.
Comment 4 Roozbeh Pournader 2006-05-17 11:37:45 UTC 
Committed to HEAD.

2006-05-17  Roozbeh Pournader  <roozbeh@farsiweb.info>

        Fix for gnome bug #341931, farsiweb #562
        * gui/contact-editor/e-contact-editor.c: Mark a few messages for
          translation.
Comment 5 André Klapper 2006-05-17 12:37:49 UTC 
i'd also like to see this committed to gnome-2-14 branch, because according to menthos' string freeze anti-confusion posting(TM) at
http://mail.gnome.org/archives/desktop-devel-list/2005-February/msg00092.html, one *can* submit fixes but should announce to gnome-i18n@gnome.org that one has marked several messages for translation that were previously not marked for translation by accident.
Comment 6 Roozbeh Pournader 2006-05-17 16:24:13 UTC 
(In reply to comment #5)
> i'd also like to see this committed to gnome-2-14 branch, [...] should announce > to gnome-i18n@gnome.org that one has
> marked several messages for translation that were previously not marked for
> translation by accident.

I will take care of both.
Comment 7 Roozbeh Pournader 2006-05-17 16:57:02 UTC 
Applied to gnome-2-14 and notified gnome-i18n.
Comment 8 André Klapper 2006-05-17 18:59:05 UTC 
cool, thanks a lot!