After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341914 - Should not force -I/opt/fdo/include
Should not force -I/opt/fdo/include
Status: RESOLVED FIXED
Product: gnome-mag
Classification: Deprecated
Component: API
0.12.x
Other Mac OS
: Normal normal
: ---
Assigned To: bill.haneman
bill.haneman
Depends on:
Blocks:
 
 
Reported: 2006-05-15 22:44 UTC by Daniel Macks
Modified: 2006-07-21 00:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Does not force -I/opt/fdo/include (1.80 KB, patch)
2006-07-20 13:58 UTC, Carlos Eduardo Rodrigues Diógenes
accepted-commit_now Details | Review

Description Daniel Macks 2006-05-15 22:44:20 UTC
Why is -I/opt/fdo/include being added to my compiler commands? It's clearly not because a needed support library was found there, as I have no such directory. Looks like it's from configure.in:

DEPS_CFLAGS="-I /opt/fdo/include $DEPS_CFLAGS"

But looking at configure, I see that -I is also added to CFLAGS as a intentional effect of a test for the various X11 extensions (XDAMAGE, etc). Why? If there's something needed, look for it; if it's sometimes not in a place that is usually searched, add it to the places that are searched. Blinding adding paths, especially "high" in the CFLAGS -I list, is a bad idea. On another system, I have a shadow OS installed there with non-standard versions of libraries installed, and I certainly don't want to use them.
Comment 1 Carlos Eduardo Rodrigues Diógenes 2006-07-20 13:57:22 UTC
I really think that this can be a mistake. By the way, attached is a patch that remove these /opt/fdo/include
Comment 2 Carlos Eduardo Rodrigues Diógenes 2006-07-20 13:58:23 UTC
Created attachment 69255 [details] [review]
Does not force -I/opt/fdo/include
Comment 3 bill.haneman 2006-07-20 22:09:03 UTC
This was a hack to support the old freedesktop.org x server.  It's no longer needed (though it would indeed be harmless on most configurations).
Comment 4 Carlos Eduardo Rodrigues Diógenes 2006-07-21 00:01:00 UTC
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.