After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341662 - gst-launch print_tags() fix
gst-launch print_tags() fix
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal blocker
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-13 17:11 UTC by Tim-Philipp Müller
Modified: 2006-05-13 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix (1.47 KB, patch)
2006-05-13 17:14 UTC, Tim-Philipp Müller
committed Details | Review

Description Tim-Philipp Müller 2006-05-13 17:11:41 UTC
The coverity scanner complained about this:

str would be used uninitialized if the tag contained a GST_IMAGE_TAG with a NULL buffer as image. Highly unlikely to ever happen, but should probably be fixed in any case, and is low risk.
Comment 1 Tim-Philipp Müller 2006-05-13 17:14:54 UTC
Created attachment 65393 [details] [review]
Fix
Comment 2 Tim-Philipp Müller 2006-05-13 17:51:05 UTC
Thanks, sorry for introducing that in a freeze in the first place.

 2006-05-13  Tim-Philipp Müller  <tim at centricular dot net>

       * tools/gst-launch.c: (print_tag):
         Fix use of uninitialized variable in the hypothetical
         case that some broken plugin creates a GST_TAG_IMAGE
         tag containing a NULL buffer (#341667).