After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 341585 - gnome-vfs-monitor does not immediately process pending events
gnome-vfs-monitor does not immediately process pending events
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Monitoring (inotify)
2.15.x
Other All
: High major
: 2.16
Assigned To: John McCutchan
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2006-05-12 21:12 UTC by Jean-Yves Lefort
Modified: 2006-07-13 16:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
the fix (3.69 KB, patch)
2006-05-12 21:12 UTC, Jean-Yves Lefort 		committed Details | Review

Description Jean-Yves Lefort 2006-05-12 21:12:06 UTC 
Events sometimes stay queued until more events are received, because actually_dispatch_callback() does not reinstall the timeout (which is needed if there are more events waiting to be processed).

That is, if there are pending events left after actually_dispatch_callback() has run, they will not be processed until another event is received by gnome_vfs_monitor_callback().

The attached patch fixes the issue.
Comment 1 Jean-Yves Lefort 2006-05-12 21:12:36 UTC 
Created attachment 65350 [details] [review]
the fix
Comment 2 Christian Kellner 2006-05-13 17:41:46 UTC 
I am reassigning that bug to Monitoring, even if its not an inotify bug, because John is the author of that piece of code.
At a first glance it looks good but I wanna wait for Johns comments. Thanks anyway :)
Comment 3 John McCutchan 2006-06-12 18:56:43 UTC 
I agree the patch looks good. Please go ahead and commit.
Comment 4 Christian Neumair 2006-07-13 16:28:14 UTC 
Changing bug status to accepted-commit_now.
Comment 5 Christian Neumair 2006-07-13 16:48:03 UTC 
Committed as per Christian Kellner's request.

Thanks for your efforts Jean-Yves! :)