GNOME Bugzilla – Bug 340775
Double click in bme opens new window
Last modified: 2007-01-18 12:48:09 UTC
Double clicking a bookmark in the bme opens a new window, but the first menu item in the right click menu is to open in a new tab...
Really? Then that is a regression, in Epiphany 1.8 which I'm using here right now the first context menu item is 'open in new window'.
Ahh, this is probably because I made everythin consistent with 'new tab' always above 'new window', see bug 303417
imho the bme should just open new tabs.
From http://bugzilla.gnome.org/show_bug.cgi?id=144087#c1: That was a design decision made in bug 109224. If you want to change it, you should initiate discussion on the mailing list.
I don't really care about the behaviour but the first item in the context menu should be the same as the double-click action. Two possible solutions. 1. Open bookmarks in new tabs. 2. Change the item order in the context menu. I think [2] is the least intrusive change.
In Ephy 2.14 the first item is Open in new window.
In 2.17 it's Open in new tab. :(. Attaching a patch to change the order so we are all happy and close bugs.
Created attachment 78910 [details] [review] Puts Open in new window over Open in new tab :)
NewTab over NewWindow was done in bug 303417; I don't think we should undo that.
Nevermind then, if Wouter doesn't mind I'm marking this as WONTFIX. Also I just thought that right clicking a bookmark has the only purpose of NOT doing the default action, so finding the default action in the context menu is just useless.
Mind that if the top item doesn't correspond to the double click action, we're going against the HIG: http://developer.gnome.org/projects/gup/hig/2.0/menus-types.html#menu-type-popup
Thanks Reinout for clarifying... that's why I filed this bug.
Ah gotcha. Then the patch has an use :P
So, what are we going to do?
As far as I'm concerned: change back the order of the context menu items so that Open in New Window is on top again, so that it corresponds with the double-click action.
Well, ok then. The patch contains unrelated change, make sure you commit only the part for this bug; trunk only.
Committed as revision 6831: 2007-01-18 Diego Escalante Urrelo <diegoe@svn.gnome.org> * data/ui/epiphany-bookmark-editor-ui.xml: Puts OpenInWindow over OpenInTab in the Bookmarks Editor so we meet the HIG. Fixes bug #340775.