After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 340069 - Allow book & page indexes as search results
Allow book & page indexes as search results
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Mikael Hallendal
Mikael Hallendal
Depends on:
Blocks:
 
 
Reported: 2006-04-28 22:52 UTC by Tristan Van Berkom
Modified: 2017-12-10 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This patch implements book and page index search results (11.36 KB, patch)
2006-04-28 22:54 UTC, Tristan Van Berkom 		none Details | Review
This patch fixes the issues in the previous patch. (12.13 KB, patch)
2006-04-29 04:04 UTC, Tristan Van Berkom 		none Details | Review

Description Tristan Van Berkom 2006-04-28 22:52:40 UTC 
The patch I am going to attach to this bug implements:

devhelp -s "book:gtk" <-- lands on the root of gtk docs

devhelp -s "book:gtk page:GtkNotebook" <-- lands on the notebook top of
                                           the page

And when a page or notebook is the exact match (i.e. there
is an empty trailing search string); then the docs of that
page or book are listed as hits alphabetically.
Comment 1 Tristan Van Berkom 2006-04-28 22:54:31 UTC 
Created attachment 64494 [details] [review]
This patch implements book and page index search results

This patch also plugs leaks on dh_keyword_model_finalize() and
fixed a critical assertion and possible segfault.
Comment 2 Tristan Van Berkom 2006-04-28 23:30:51 UTC 
Hmmm, seems there are still some completion bugs on this one...

If you have a book selected and a page selected and a search string,
the exact match becomes the page :-/

I think this is because of the sort algorythm and the hitlist stuff
... looking into it ...
Comment 3 Tristan Van Berkom 2006-04-29 04:04:38 UTC 
Created attachment 64497 [details] [review]
This patch fixes the issues in the previous patch.
Comment 4 Richard Hult 2006-04-29 06:17:33 UTC 
Thanks, this look fine. Please commit!
Comment 5 Tristan Van Berkom 2006-04-29 14:45:14 UTC 
Done, closing bug.
Comment 6 Sébastien Wilmet 2017-12-10 15:18:16 UTC 
Tristan: it's you who implemented this feature a decade ago, I maybe plan to remove it, see:

https://bugzilla.gnome.org/show_bug.cgi?id=791442