GNOME Bugzilla – Bug 340049
New BaseRTPAudioPayloader class to -base
Last modified: 2006-10-31 15:14:42 UTC
Would like to get a new base class for RTP into -base. It's a base class for audio payloaders and supports most sample or frame based audio codecs. There are already 2 example elements using it that will be in -bad (ilbcpayloader and pcm[au]payloader). Attached is the new file.
Created attachment 64484 [details] [review] New base class for audio payloaders Needs approval then I can commit.
Some very basic things that need fixing before I'd spend the time for a thorough review: 1) Define padding appropriately. 2) Tests 3) 80 column lines 4) Why is GST_RTP_MIN_PTIME_MS fixed, not configurable? 5) Fix up TODOs 6) Documentation. LOTS of documentation.
Will fix and rewrite without the gst_adapter, after thinking about it RTP packets should NEVER be delayed in the adapter. Therefore I will get rid of it completly as well as that TODO about keeping them in the adapter. About the tests, I guess the only way to test is with some elements that use this base class?
Ok I fixed up and added some docs. Since I had already commited this to CVS previously, I updated the CVS but the base class is disabled in the Makefile.am until approval. If someone could review it would be great : http://webcvs.freedesktop.org/*checkout*/gstreamer/gst-plugins-base/gst-libs/gst/rtp/gstbasertpaudiopayload.c?rev=1.3&content-type=text%2Fplain http://webcvs.freedesktop.org/*checkout*/gstreamer/gst-plugins-base/gst-libs/gst/rtp/gstbasertpaudiopayload.h?content-type=text%2Fplain Docs at http://webcvs.freedesktop.org/*checkout*/gstreamer/gst-plugins-base/gst-libs/gst/rtp/README?rev=1.2
More minor fixes. Latest at : http://webcvs.freedesktop.org/*checkout*/gstreamer/gst-plugins-base/gst-libs/gst/rtp/gstbasertpaudiopayload.c?rev=1.4&content-type=text%2Fplain An example child element (ilbcpayloader) http://webcvs.freedesktop.org/gstreamer/gst-plugins-good/gst/rtp/gstrtpilbcpay.c?rev=1.1&view=markup
Another example (pcmapayloader) sample based : http://webcvs.freedesktop.org/*checkout*/gstreamer/gst-plugins-good/gst/rtp/gstrtppcmapay.c?rev=1.4&content-type=text%2Fplain
Guess we can close this then: 2006-10-31 Wim Taymans <wim@fluendo.com> * gst-libs/gst/rtp/Makefile.am: * gst-libs/gst/rtp/gstbasertpaudiopayload.c: (gst_base_rtp_audio_payload_init): Fix and activate base audio payloader.