After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 339986 - Patch to select localized strings exactly
Patch to select localized strings exactly
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other opensolaris
: Normal normal
: ---
Assigned To: Behdad Esfahbod
VTE Maintainers
: 156279 170668 341717 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-04-28 01:40 UTC by Brian Cameron
Modified: 2007-01-31 23:23 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
patch fixing problem (442 bytes, patch)
2006-04-28 01:40 UTC, Brian Cameron 		committed Details | Review

Description Brian Cameron 2006-04-28 01:40:19 UTC 
This problem fixes the problem of when you display a multibyte word you can't select the word exactly.
Comment 1 Brian Cameron 2006-04-28 01:40:56 UTC 
Created attachment 64439 [details] [review]
patch fixing problem
Comment 2 Behdad Esfahbod 2006-04-28 03:23:16 UTC 
I like the idea (though not the duplication of those three lines).  Just wondering, where does the 0xa0 come from?  It probably doesn't make any difference, but I suggest 0x80 instead.  So we fallback to the default for all non-ASCII chars.  Or maybe remove that check completely.  What it means is that A-Z, a-z, and 0-9 will always be word chars no matter what the set ranges are.  I cannot imagine someone wanting to remove any of them from the word chars.  What do you think?
Comment 3 Behdad Esfahbod 2006-05-14 20:31:13 UTC 
*** Bug 170668 has been marked as a duplicate of this bug. ***
Comment 4 Behdad Esfahbod 2006-05-14 20:45:21 UTC 
*** Bug 341717 has been marked as a duplicate of this bug. ***
Comment 5 Takao Fujiwara 2006-05-15 04:19:57 UTC 
Yes, 0x80 is ok instead of 0xa0.
I think the original bug is #170668 and this is a duplicated bug.
Comment 6 Behdad Esfahbod 2006-05-15 06:05:33 UTC 
I dupped 170668.  Doesn't matter.
Comment 7 Behdad Esfahbod 2006-07-10 18:41:26 UTC 
I committed a functionally similar patch without the code duplication.

2006-07-10  Behdad Esfahbod  <behdad@gnome.org>

        Bug 339986 – Patch to select localized strings exactly
        Patch from Takao Fujiwara

        * src/vte.c (vte_terminal_is_word_char): Fall back on Unicode
        properties for non-ASCII characters or when no array is set.
Comment 8 Chris Wilson 2007-01-31 23:23:47 UTC 
*** Bug 156279 has been marked as a duplicate of this bug. ***