After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 339618 - Remote file names are incorrectly handled in UTF-8 environment. (with patch)
Remote file names are incorrectly handled in UTF-8 environment. (with patch)
Status: RESOLVED DUPLICATE of bug 156371
Product: gftp
Classification: Other
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: Brian Masney
Brian Masney
Depends on:
Blocks:
 
 
Reported: 2006-04-24 18:22 UTC by Hong Jen Yee
Modified: 2006-10-23 05:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch fixing the bug (7.82 KB, patch)
2006-10-23 05:16 UTC, Hong Jen Yee
none Details | Review

Description Hong Jen Yee 2006-04-24 18:22:35 UTC
When gftp is used under UTF-8 locale, remote filenames cannot be properly processed.  Though there is "remote charset" in settings, it's totally broken and useless. Downloaded files will be in remote charset, not my on-disk encoding, UTF-8, and names of uploaded files will always be encoded in UTF-8, not remote charset. This cause no problem if gftp is used under English enviroment; otherwise, all filename-related things are in a mess. I made a patch for this, which "almost" fixes all these problems. The patch is tested under zh_TW.UTF-8 locale and zh_TW.Big5 locale, both have no problems. Only one thing should be mentioned, when this patch is used under non-UTF-8 environment, the environment G_FILENAME_ENCODING of gtk+ should be set properly. (This is the requirement of gtk+ 2 itself, not gftp or my patch.)

Here is my patch:
http://pcman.sayya.org/gftp/gftp-2.0.18-11-pcman.diff.gz

This patch has been tested by many friends and no problem found.
Comment 1 Brian Masney 2006-07-20 10:25:35 UTC

*** This bug has been marked as a duplicate of 156371 ***
Comment 2 Hong Jen Yee 2006-10-23 05:16:04 UTC
Created attachment 75225 [details] [review]
Patch fixing the bug