After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 339496 - Reduce memory usage in toc
Reduce memory usage in toc
Status: RESOLVED OBSOLETE
Product: yelp
Classification: Applications
Component: Directory
git master
Other Linux
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-23 20:16 UTC by Brent Smith (smitten)
Modified: 2018-05-22 12:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to move CSS style definitions to toc.css file (5.07 KB, patch)
2006-04-23 20:17 UTC, Brent Smith (smitten) 		needs-work Details | Review

Description Brent Smith (smitten) 2006-04-23 20:16:01 UTC 
Yelp processes the data/{toc.xml,man.xml,info.xml} file using stylesheet/toc2html.xsl.  This file has a little more than 1KB in CSS data specified at the top of the file.  Since yelp creates a YelpPage for each toc category, this 1KB of data gets duplicated in memory.  With around 50 categories this leads to around 60KB of in memory data that could be avoided if we just include a link to a CSS stylesheet on disk.

Note that there are some dynamic values that are passed in to the stylesheet, so those are kept in the toc2html.xsl stylesheet.

Of course, moving to the YelpDocument api will give us the ability to do on-demand page loads (for the TOC at least), and we won't have to store all the toc pages in memory, which will save us a lot more memory.

The patch will follow shortly.
Comment 1 Brent Smith (smitten) 2006-04-23 20:17:39 UTC 
Created attachment 64165 [details] [review]
patch to move CSS style definitions to toc.css file
Comment 2 Brent Smith (smitten) 2006-07-01 14:43:09 UTC 
This actually doesn't seem to reduce the heap size but increases it by about 2M!  The mozilla library might be initializing some CSS functions now that it wasn't before, therefore I'm putting this patch on hold till I can make more sense of this.
Comment 3 Don Scorgie 2006-08-07 18:50:44 UTC 
Marking patch as "needs-work" in line with smittens comment.
Comment 4 GNOME Infrastructure Team 2018-05-22 12:41:03 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/yelp/issues/12.