After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338831 - [PATCH] gnome-session may crash on 64-bit platforms due to pointer truncation
[PATCH] gnome-session may crash on 64-bit platforms due to pointer truncation
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
2.14.x
Other FreeBSD
: Normal critical
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-17 22:09 UTC by Joe Marcus Clarke
Modified: 2006-04-24 21:55 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Properly prototype gsm_get_conf_client() (268 bytes, patch)
2006-04-17 22:10 UTC, Joe Marcus Clarke 		committed Details | Review
Properly prototype gsm_get_conf_client() (253 bytes, patch)
2006-04-17 22:11 UTC, Joe Marcus Clarke 		committed Details | Review

Description Joe Marcus Clarke 2006-04-17 22:09:42 UTC 
There are two modules in gnome-session that are missing an include for util.h.  Because of this, the gsm_get_conf_client() function is not properly prototyped.  Since this function returns a pointer, that's a problem, because without a protoype, GCC determines that the pointer returns an int.  The result can cause crashes on 64-bit platforms such as amd64.

Attached are patches to correct both instances.
Comment 1 Joe Marcus Clarke 2006-04-17 22:10:45 UTC 
Created attachment 63746 [details] [review]
Properly prototype gsm_get_conf_client()
Comment 2 Joe Marcus Clarke 2006-04-17 22:11:13 UTC 
Created attachment 63747 [details] [review]
Properly prototype gsm_get_conf_client()
Comment 3 Vincent Untz 2006-04-24 21:55:20 UTC 
Thanks