After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338824 - Make search ignore diacritical marks
Make search ignore diacritical marks
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 400332 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-04-17 20:47 UTC by jchirac
Modified: 2007-03-27 10:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (679 bytes, patch)
2006-04-19 05:43 UTC, James "Doc" Livingston
none Details | Review

Description jchirac 2006-04-17 20:47:57 UTC
Whenever I filter my library on a term let's say "Alizee", Rhythmbox doesn't display the songs containing the "Alizée"-tag. It would be better if Rhythmbox didn't make any distinction between these irrelevant differences. Could this be changed?
Comment 1 Alex Lancaster 2006-04-18 08:25:53 UTC
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

Also, which version of rhythmbox is this?



*** This bug has been marked as a duplicate of 139196 ***
Comment 2 jchirac 2006-04-18 15:50:04 UTC
Ah, I see. Sorry, but I didn't know what to look for.

This was in version 0.8.8 (Gentoo x86)
Comment 3 James "Doc" Livingston 2006-04-19 04:12:35 UTC
Although this is included in the current description of bug 139196, I think it would be better to separate them. Ignoring diacritical marks is probably easier to do and less controversial. I'm re-titling bug 139196 to reflect the other bit, ignoring typos/different spelling/whatever.

Does anyone know if there is a library (or algorithm) for stripping diacritical marks? If so, this should be trivial to do.
Comment 4 James "Doc" Livingston 2006-04-19 05:43:32 UTC
Created attachment 63845 [details] [review]
patch

This actually turns out to be fairly easy to do. The patch will need some testing to ensure it doesn't strip out too much, as in some languages the diacritical marks aren't irrelevent and they are different letters.
Comment 5 Nguyen Thai Ngoc Duy 2006-05-30 08:13:19 UTC
It works fine with Vietnamese. I highly appreciate this patch.
Comment 6 Nguyen Thai Ngoc Duy 2006-06-28 09:34:11 UTC
Side note, some characters doesn't work with this patch. Those (such as đ/d, ç/c) might be out of scope of this bug although I would rather those characters working too.
As for some suspicuous languages, this patch should be an option instead of a hard-coded feature. I might need to search with diacritics sometimes. I'm thinking about enabling this feature only in searchbar with a checkbox beside, allowing people to search with diacritics or not. However, it seems hard to do with searchbar only.
Comment 7 Jonathan Matthew 2007-01-24 22:57:10 UTC
*** Bug 400332 has been marked as a duplicate of this bug. ***
Comment 8 James "Doc" Livingston 2007-03-27 10:22:10 UTC
This should have been fixed by the patch from bug 421253 which I just committed to svn trunk.