After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338623 - rename series: can't change filename extension, crash if no file extension
rename series: can't change filename extension, crash if no file extension
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.7.x
Other All
: High critical
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
: 339037 383893 434556 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-04-15 16:46 UTC by Per Bothner
Modified: 2007-04-30 11:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to remove hard-coding of extension in series renaming (2.30 KB, patch)
2006-09-01 15:10 UTC, Michael Chudobiak 		none Details | Review
Revised patch, fixes Bug 339037 as well (3.40 KB, patch)
2006-09-22 14:30 UTC, Michael Chudobiak 		none Details | Review

Description Per Bothner 2006-04-15 16:46:38 UTC 
My camera produces files named DSCFnnn.JPG.
I want to rename the filename extension JPG by jpg, but "Rename Series" doesn't
appear to let me do it.
I suggest only adding the extension to the "New Name" only if there is no
explicit filename extension.  Currently, if the Template is Xxxx#.jpg then the
New Name is displayed as Xxxx#.jpg.JPG.
(GQView does allow me to change the extension.)
Comment 1 Niels Weber 2006-08-30 12:31:07 UTC 
I's like to support that request. Right now I have to use the command line (rename JPG jpg *.jpg) when I want to make the extension lowercase.
Comment 2 Michael Chudobiak 2006-09-01 15:10:59 UTC 
Created attachment 72027 [details] [review]
Patch to remove hard-coding of extension in series renaming

This is my attempt at a patch that removes the automatic insertion of the original extension, and adds an optional "%e" specifier (used by default in the template) to insert the original extension.
Comment 3 Michael Chudobiak 2006-09-22 14:30:59 UTC 
Created attachment 73213 [details] [review]
Revised patch, fixes Bug 339037 as well

The revised patch fixes a crash that occurs if the user attempts to rename files that have no extensions. See bug #339037.
Comment 4 Michael Chudobiak 2006-09-22 14:34:51 UTC 
*** Bug 339037 has been marked as a duplicate of this bug. ***
Comment 5 Michael Chudobiak 2006-09-22 15:42:02 UTC 
Boosting severity, because the application crashes if the user attempts to rename a series of files that have no extension.
Comment 6 Michael Chudobiak 2006-10-21 19:21:13 UTC 
See http://bugzilla.gnome.org/show_bug.cgi?id=305046#c3 for a new roll-up patch.
Comment 7 Michael Chudobiak 2006-11-01 14:06:29 UTC 
Patch committed to CVS HEAD.
Comment 8 Michael Chudobiak 2006-12-09 00:06:45 UTC 
*** Bug 383893 has been marked as a duplicate of this bug. ***
Comment 9 Michael Chudobiak 2007-04-30 11:32:22 UTC 
*** Bug 434556 has been marked as a duplicate of this bug. ***