After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338390 - Rework the fullscreen popup's UI
Rework the fullscreen popup's UI
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other All
: Normal enhancement
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 339753 349402 350648 353271 393590 445178 458495 518776 634797 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-04-13 21:22 UTC by Sven Rech
Modified: 2010-11-14 15:42 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
1st picture (10.49 KB, image/png)
2006-04-13 22:33 UTC, Sven Rech
  Details
2. picture (9.29 KB, image/png)
2006-04-13 22:36 UTC, Sven Rech
  Details
Small fix (2.46 KB, patch)
2006-08-06 21:41 UTC, Marc-Andre Lureau
needs-work Details | Review
OneLiner: set fixed size for time label in fullscreen mode (25 char) (569 bytes, patch)
2007-09-10 23:40 UTC, Kristian Mueller
none Details | Review

Description Sven Rech 2006-04-13 21:22:30 UTC
Please describe the problem:
When beeing in Fullscreen, there are problems with the scale adjustments. But I
don't know if this is only in the german translation version.

Hard to explain for a non native speaker ^^

Steps to reproduce:
1. Go fullscreen
2. Now click on the scale thing and hold down the mouse
3. Now you can see, that the scalebar is smaller now than before. This is
because of the "jump to" text, wich appears next to it.


Actual results:


Expected results:
The scale should always stay the same size. Because, if you are new the end of a
film, and then click on the scale widget, the scale widget gets smaller, and
your mouse sets the scale on the end of the film

Does this happen every time?
yes

Other information:
If you don't know what I mean, then please ask. I can make pictures to explain it.
Comment 1 Sergej Kotliar 2006-04-13 21:33:21 UTC
Yeah, I don't understand...
What is this scale widget you're talking of? There shouldn't be any scaling when in fullscreen AFAIK....
Comment 2 Sven Rech 2006-04-13 22:33:39 UTC
Created attachment 63413 [details]
1st picture
Comment 3 Sven Rech 2006-04-13 22:36:12 UTC
Created attachment 63415 [details]
2. picture

This is the bar, that appears when moving the mouse in fullscreen.
You see the problem?

If you now thing "that is no real problem", then try it out:
Try to move the movie to a special position near the end with this scale.
Comment 4 Bastien Nocera 2006-05-10 14:25:19 UTC
*** Bug 339753 has been marked as a duplicate of this bug. ***
Comment 5 Marc-Andre Lureau 2006-08-06 21:41:42 UTC
Created attachment 70342 [details] [review]
Small fix

I found this bug annoying, hence I have done a quick patch

Personnal comment: would it be nice to have a layout with more ratios/constraints of widgets ?

The time slider might have a fixed size too to solve the quirks when a label change.
Comment 6 Bastien Nocera 2006-08-06 23:32:30 UTC
The fullscreen toolbar is an absolute pain layout-wise. I've tried many times to make it smoother but failed each time.
Other takers welcome.
Comment 7 Bastien Nocera 2006-08-13 00:50:24 UTC
*** Bug 350648 has been marked as a duplicate of this bug. ***
Comment 8 Bastien Nocera 2006-09-11 11:03:43 UTC
*** Bug 349402 has been marked as a duplicate of this bug. ***
Comment 9 Bastien Nocera 2006-11-03 14:51:10 UTC
*** Bug 353271 has been marked as a duplicate of this bug. ***
Comment 10 Bastien Nocera 2007-01-08 22:58:36 UTC
*** Bug 393590 has been marked as a duplicate of this bug. ***
Comment 11 Patrick Ammann 2007-01-17 20:14:51 UTC
Variant 1:
--------------------------------------------
|                       | Leave Fullscreen |
|                       --------------------        
|                                          |
|                                          |
|                                          |
|                                          |
|                                          |
|                                          |
|                                          |
|                                          |
|                                          |
|                                          |
--------------------------------------------
| < || > Time: [---------]   Volume [----] |
--------------------------------------------
| 0:00 / 1:10:20                           |
--------------------------------------------

Variant 2:
In case we would use a monospace font for the time and save enough
space the scroller should not bump.
Comment 12 Bastien Nocera 2007-01-18 00:08:33 UTC
(In reply to comment #11)
> Variant 1:
<snip>
> Variant 2:
> In case we would use a monospace font for the time and save enough
> space the scroller should not bump.

It's not so much how it could look, but how will it look/how will it be implemented. Ie. No mockups allowed, only glade patches :)

(Actually, mockups allowed if somebody is interested in working on a cairo-based/compositing-fu popup, see bug 397824)
Comment 13 Philip Withnall 2007-06-26 22:06:24 UTC
*** Bug 445178 has been marked as a duplicate of this bug. ***
Comment 14 Philip Withnall 2007-07-20 12:25:27 UTC
*** Bug 458495 has been marked as a duplicate of this bug. ***
Comment 15 Kristian Mueller 2007-09-10 23:40:51 UTC
Created attachment 95316 [details] [review]
OneLiner: set fixed size for time label in fullscreen mode (25 char)

25 chars is open for discussion - but strings like "99:59:59 / 99:59:59" can already get 19 chars long - so 25 should be min. for most languages - and still be okay in normal situations...
Comment 16 Bastien Nocera 2008-02-26 18:30:40 UTC
*** Bug 518776 has been marked as a duplicate of this bug. ***
Comment 17 Jakub 'Livio' Rusinek 2008-02-26 19:57:18 UTC
Bastien marked my bug as duplicate but this bug is about clutter and little space for progress slider, while I proposed NEW fullscreen overlay [ie. clutter-libs based].
Comment 18 Bastien Nocera 2008-02-27 14:12:28 UTC
(In reply to comment #17)
> Bastien marked my bug as duplicate but this bug is about clutter and little
> space for progress slider, while I proposed NEW fullscreen overlay [ie.
> clutter-libs based].

This bug is actually about a whole new UI.
Comment 19 Jakub 'Livio' Rusinek 2008-02-27 14:20:13 UTC
O rly?

> there are problems with the scale adjustments
Comment 20 Mike McWay 2008-06-25 02:51:02 UTC
is it possible to make totem use clutter fullscreen through a plugin? rather than adding that dependency for everyone
Comment 21 Wagner Volanin 2008-10-21 21:22:03 UTC
I believe this BUG has already been fixed.

I am using Totem 2.22.1 in Ubuntu Hardy, and clicking and dragging
the POSITION BAR (called by the submitter as SCALE) does not make
this bar smaller anymore, as it used to happen in previous versions.

Please, confirm this and mark the bug as FIXED.

Steps to confirm:

1. Open any movie in Totem 2.22.1 or later.
2. Enter fullscreen mode by pressing 'F'
3. Click on the slider in the POSITION BAR to advance/rewind the movie
and check if this bar resizes. It shouldn't.
Comment 22 Bastien Nocera 2008-10-21 21:46:47 UTC
Indeed, was already fixed as part of bug 469413 (in 2.21.0, and probably some 2.20.x update).

2007-08-25  Bastien Nocera  <hadess@hadess.net>

        * src/totem-menu.c: (skip_forward_action_callback),
        (skip_backwards_action_callback):
        * src/totem.c: (totem_seek_time_rel), (totem_action_seek_relative),
        (totem_action_seek_time), (totem_action_remote),
        (totem_action_handle_key_release), (totem_action_handle_seek),
        (totem_action_handle_key_press), (totem_action_handle_scroll):
        * src/totem.h: Clean up the seek to time functions, and don't
        set the statusbar or the full screen label as seeking when
        there's no MRL loaded (Closes: #469413)
Comment 23 Robin Stocker 2008-10-21 22:00:27 UTC
Sorry, I can't confirm that this bug is fixed, the position bar still gets smaller when seeking with the slider because the text "Seek to" or "Zu ... springen" appears. I tried Totem from trunk as well as 2.24.2 and both in German and English.
Comment 24 Wagner Volanin 2008-10-21 22:11:11 UTC
(In reply to comment #23)
> Sorry, I can't confirm that this bug is fixed, the position bar still gets
> smaller when seeking with the slider because the text "Seek to" or "Zu ...
> springen" appears. I tried Totem from trunk as well as 2.24.2 and both in
> German and English.

Indeed.
I mistakenly tested this in a patched version that removed the "Seek to" text.
It was my bad and I really apologize for the error.

I just tried 2.24 and the bug is still there.
When the text "Seek to" appears, it does resize the POSITION BAR.

Please, reopen the bug.
Thank you Robin.
Comment 25 Bastien Nocera 2008-10-22 10:06:25 UTC
This is the best we can do without changing the layout of the fullscreen popups. Fixed in gnome-2-24 and trunk

2008-10-22  Bastien Nocera  <hadess@hadess.net>

	* src/totem.c (seek_slider_pressed_cb): Don't show seeking to
	label when we can direct seek (Closes: #338390)
Comment 26 Philip Withnall 2010-11-14 10:56:31 UTC
*** Bug 634797 has been marked as a duplicate of this bug. ***
Comment 27 Omer Akram 2010-11-14 13:07:41 UTC
is it necessary to show 'seek'? wouldn't the after effect of scrolling itself tell the user what happened?
Comment 28 Philip Withnall 2010-11-14 15:31:45 UTC
(In reply to comment #27)
> is it necessary to show 'seek'? wouldn't the after effect of scrolling itself
> tell the user what happened?

I believe it's necessary to give the user feedback that their seek operation is happening. It's only shown for streams where Totem can't do a direct seek (i.e. it may take an unbounded amount of time for the seek to complete).
Comment 29 Omer Akram 2010-11-14 15:42:12 UTC
> It's only shown for streams where Totem can't do a direct seek (i.e.
> it may take an unbounded amount of time for the seek to complete).

I see it with every audio/video file