After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338017 - [Patch] Use po/LINGUAS and intltool
[Patch] Use po/LINGUAS and intltool
Status: RESOLVED FIXED
Product: eel
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-10 20:08 UTC by Przemysław Grzegorczyk
Modified: 2006-04-27 22:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use po/LINGUAS file and add support for intltool (1.96 KB, patch)
2006-04-10 20:09 UTC, Przemysław Grzegorczyk
none Details | Review
New po/LINGUAS patch (1.64 KB, patch)
2006-04-14 14:50 UTC, Przemysław Grzegorczyk
committed Details | Review

Description Przemysław Grzegorczyk 2006-04-10 20:08:32 UTC
http://live.gnome.org/GnomeGoals/PoLinguas
Here is a patch which adds intltool support and uses po/LINGUAS file
Comment 1 Przemysław Grzegorczyk 2006-04-10 20:09:31 UTC
Created attachment 63197 [details] [review]
Use po/LINGUAS file and add support for intltool
Comment 2 Martin Wehner 2006-04-10 20:24:27 UTC
I've just committed the patch at bug 337948 which does basically the same.
What are the DISTCLEANFILES change and the new AC_PROG_INTLTOOL check in your patch about?
Comment 3 Martin Wehner 2006-04-10 20:30:55 UTC
Oh, just noticed that's an eel patch. Nevermind.
Comment 4 Przemysław Grzegorczyk 2006-04-10 20:38:23 UTC
I used to DISTCLEANFILES in Makefiles and also i saw it in intltool README when
i was adding support for intltool. So I thougth that was a mistake.
I added intltool support because on http://live.gnome.org/GnomeGoals/PoLinguas
is writen:
"...Second, make sure that the module is using intltool; search for INTLTOOL in
configure.ac. If not found, file a bug about it...".
Thats why I added AC_PROG_INTLTOOL and changed Makefile.am.
Comment 5 Martin Wehner 2006-04-10 20:56:48 UTC
Great, thanks. It'll be in 2.14.1:

2006-04-10  Martin Wehner  <martin.wehner@gmail.com>

	* Makefile.am: Add intltool artefacts.

	* po/LINGUAS: New file listing all supported languages.

	* configure.in: Require intltool and use po/LINGUAS instead of including
	all languages directly in this file. See the wiki for more information:
	http://live.gnome.org/GnomeGoals/PoLinguas

	Patch from Przemyslaw Grzegorczyk  <pgrzegorczyk@gmail.com>
Comment 6 Przemysław Grzegorczyk 2006-04-14 14:50:52 UTC
Created attachment 63468 [details] [review]
New po/LINGUAS patch

This patch is based on a new guidelines (http://live.gnome.org/GnomeGoals/PoLinguas).
It's a diff against current CVS HEAD.
Comment 7 Martin Wehner 2006-04-27 22:21:31 UTC
Comment on attachment 63468 [details] [review]
New po/LINGUAS patch

It's on HEAD, thank you.

2006-04-28  Martin Wehner  <martin.wehner@gmail.com>

	* configure.in:  
	* po/LINGUAS:
	Update po/LINGUAS support to new guidelines. (#338017)

	Patch from Przemyslaw Grzegorczyk  <pgrzegorczyk@gmail.com>