After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337969 - [Patch] Use po/LINGUAS
[Patch] Use po/LINGUAS
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: David Bolter
David Bolter
Depends on:
Blocks:
 
 
Reported: 2006-04-10 16:31 UTC by Przemysław Grzegorczyk
Modified: 2006-05-10 14:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use po/LINGUAS file (1.15 KB, patch)
2006-04-10 16:32 UTC, Przemysław Grzegorczyk
none Details | Review
New po/LINGUAS patch (1.36 KB, patch)
2006-04-14 13:36 UTC, Przemysław Grzegorczyk
accepted-commit_now Details | Review
Updated patch (1.35 KB, patch)
2006-05-06 08:32 UTC, Przemysław Grzegorczyk
committed Details | Review

Description Przemysław Grzegorczyk 2006-04-10 16:31:19 UTC
http://live.gnome.org/GnomeGoals/PoLinguas
Here is a patch to use po/LINGUAS file
Comment 1 Przemysław Grzegorczyk 2006-04-10 16:32:18 UTC
Created attachment 63154 [details] [review]
Use po/LINGUAS file
Comment 2 David Bolter 2006-04-12 14:25:36 UTC
I'm not sure what to do with this patch after reading comments in bug #337983
Comment 3 Przemysław Grzegorczyk 2006-04-14 13:36:01 UTC
Created attachment 63462 [details] [review]
New po/LINGUAS patch

This patch is based on new guidelines (http://live.gnome.org/GnomeGoals/PoLinguas).
Comment 4 Brian Cameron 2006-04-17 21:52:08 UTC
Fixed in CVS head.  Updated the LINGUAS file so it matched what was already in CVS head.  Some languages were missing from your patch.
Comment 5 Brian Cameron 2006-04-17 22:02:09 UTC
Sorry, I did not fix this problem.  I thought this was a GDM bug.  Whoops.
Comment 6 David Bolter 2006-05-04 20:10:45 UTC
Przemyslaw, would you like to update and commit this patch?
Comment 7 Przemysław Grzegorczyk 2006-05-06 08:32:50 UTC
Created attachment 64907 [details] [review]
Updated patch

I don't have CVS account.
Comment 8 David Bolter 2006-05-09 16:38:19 UTC
Przemyslaw... I'd like to commit your patch but my local sandbox is not able to build ATM so I can't confirm this is safe ...  any ideas what is going on here?

config.status: creating gok/Makefile
config.status: executing depfiles commands
make[2]: Leaving directory `/home/dtb/sandboxes/cvs.gnome.org/gok/gok'
make[2]: Entering directory `/home/dtb/sandboxes/cvs.gnome.org/gok/gok'
LC_ALL=C ../intltool-merge -o -u -c ../po/.intltool-merge-cache ../po GNOME_Gok.server.in GNOME_Gok.server
Possible unintended interpolation of @INTLTOOL_LIBDIR in string at ../intltool-merge line 260.
Global symbol "@INTLTOOL_LIBDIR" requires explicit package name at ../intltool-merge line 260.
Execution of ../intltool-merge aborted due to compilation errors.
make[2]: *** [GNOME_Gok.server] Error 255
make[2]: Leaving directory `/home/dtb/sandboxes/cvs.gnome.org/gok/gok'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/dtb/sandboxes/cvs.gnome.org/gok'
make: *** [all] Error 2
Comment 9 David Bolter 2006-05-09 20:45:54 UTC
Figured out my build problem.  Patch will go in tomorrow.
Comment 10 David Bolter 2006-05-10 14:03:26 UTC
committed thanks!

2006-05-10  David Bolter  <david.bolter@utoronto.ca>

        Thanks for this patch Przemyslaw Grzegorczyk.

        * configure.in: changes made to reflect new po linguas setup
        including removing ALL_LINGUAS (now in new file LINGUAS), and
        updating AC_PROG_INTLTOOL to IT_PROG_INTLTOOL version 0.34.90
        Fixes bug #337969
        * po/LINGUAS: new file