GNOME Bugzilla – Bug 337936
Maybe combine % and remaining columns
Last modified: 2011-03-07 20:43:19 UTC
I thought perhaps it would be nice to combine the % and time reminaing columns in the downloads window. This may be complete crack but I thought i'd do a quick mockup anyway before I forget... screenshot to follow.
Created attachment 63111 [details] Mockup
Created attachment 63112 [details] Current downloads window for comparision
Btw the column would also be renamed "Progress" and maybe moved to the right side of the window (since i'd think it'd look nicer there). Comments?
(In reply to comment #3) > Btw the column would also be renamed "Progress" and maybe moved to the right > side of the window (since i'd think it'd look nicer there). Comments? Yeah, that sounds about right. Looks good to me!
Created attachment 69230 [details] [review] Makes the downloads window look like the proposed mock up I made the necessary changes to embed/downloader-view.c so it looks like the mock up, BUT I can't make it align everything to the center, I'm not sure how to do this in a GtkCellRendererProgress. Also I think that instead of 'about X left' it should just say 'X left', the strings I'm using in the patch are of course just an example and they are screaming to get changed for something smarter.
Created attachment 69242 [details] Downloads window with the patch applied As you can see, the column to the right sports the new format of % and time remaining (Faltan means Left [as in remaining] in spanish) but it looks rather ugly because I couldn't center it.
Created attachment 69248 [details] [review] Follows Reinout's suggestions of putting the % in the File column and naming the % column 'Time left' This patch will make a nicer version of the downloads window, I think it's more intuitive, I also added some ifs to make time measurement more relative. Einstein would be proud. However I don't like the bump effect when you pass from 'About X hours and X minutes' to 'About X and a half hours'. See the next comment/attachment for a screenshot of how does it looks like now.
Created attachment 69249 [details] Downloads window with the patch applied
Created attachment 69281 [details] [review] Yet another patch, this lets the Time left column to be resized and also cuts it in two lines This new patch makes the Time left column split in two lines so it doesn't take too much space.
Created attachment 69282 [details] Screenshot of the latest patch This is how the downloads window looks now
When more than 24 hours are left, the text should be 'X days' also.
*** Bug 328674 has been marked as a duplicate of this bug. ***
Ping. Are we getting mathusalem on 2.18 or this can be applied? Also, how can I make the right column wider so the text is not so tight.
+ if (secs >= 27 && secs >= 30 && secs <= 33) { ?? Also, indentation is wrong (using 4 spaces instead of a 8-space tab). + text = "Paused"; Missing i18n. + //We don't have a relevant state to give, so we add our fancy relative remaining time + if (!text) { + text = g_strdup_printf(Q_("About %s"), remaining); + } Use _() not Q_() here. + //liststore = gtk_list_store_new (6, Just remove it, don't comment it out.
Created attachment 78536 [details] [review] Follows suggestions and comments. Major change is that now it says "N hours" instead of "About N hours" since I removed the "half an hour" part. When/If committed this should close bug #341753 too.
+ if (mins > 1) + { + return g_strdup_printf (ngettext("%u hour\nand %u minutes", "%u hours\nand %u minutes", hours), hours, mins); + } + return g_strdup_printf (ngettext("%u hour", "%u hours", hours), hours); This should ngettext the "minutes" part separately and then put the strings together. However the latest screenshot (attachment 69282 [details]) makes me doubt a bit we should do this...
*** Bug 341753 has been marked as a duplicate of this bug. ***
The just committed bug #618443 (new downloads UI) makes this bug(s) obsolete.