Created attachment 66209 [details] [review]
Makes cookie list sortable by domain and by name

Obvious patch and it compiles but I did this remotely and couldn't test the epiphany binary it produced.

Thanks for the patch!

The change for the cookie data name column is ok, but the first column doesn't work right: When I click the column header the sorting changes to [reverse] alphabetical, not to [reverse] domain-based sorting as is done by default. This needs to take into account the custom sort function

Created attachment 66460 [details] [review]
Makes cookie list sortable by domain and by name

Luckily it was really easy, just a matter of changing the model key.

Site note: I don't know which changes warrant ChangeLog entries, I added one to this.

Thanks for the patch! Please commit to HEAD and gnome-2-14.

> Site note: I don't know which changes warrant ChangeLog entries, I added one to
> this.

ALL commits MUST have ChangeLog entries (and use the ChangeLog entry as commit message, using cvs commit -m "`head -NUMBER ChangeLog`") . Since you have cvs commit access (i.e. you're commiting the patch yourself), it's customary to only write it on commit, not putting it in the patch :)

Commited (someday I'll ask for editbugs priviledges but today you will have to close this bug).

(In reply to comment #5)
> (someday I'll ask for editbugs priviledges but today you will have to
> close this bug).

Granted.