After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337786 - desktop-file-validate should verify Categories
desktop-file-validate should verify Categories
Status: RESOLVED FIXED
Product: desktop-file-utils
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Maintainers of desktop-file-utils
Maintainers of desktop-file-utils
Depends on:
Blocks:
 
 
Reported: 2006-04-09 10:55 UTC by Sebastien Bacher
Modified: 2007-01-22 17:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch by Emmet Hikory <emmet.hikory@gmail.com> (3.68 KB, patch)
2006-04-09 10:57 UTC, Sebastien Bacher 		none Details | Review
Updated patch without the typo (3.88 KB, patch)
2006-04-15 10:47 UTC, Vincent Untz 		committed Details | Review

Description Sebastien Bacher 2006-04-09 10:55:18 UTC 
That bug has been opened on https://launchpad.net/distros/ubuntu/+source/desktop-file-utils/+bug/38804

"The desktop-file-validate program should validate the Categories entry against the known categories in the specification.

http://librarian.launchpad.net/1985952/category-match.diff
There doesn't seem to be a patch architecture already in use in the package, but src/validate.c with this patch will check the categories against 1.0-draft4.
..."
Comment 1 Sebastien Bacher 2006-04-09 10:57:49 UTC 
Created attachment 63010 [details] [review]
patch by Emmet Hikory <emmet.hikory@gmail.com>
Comment 2 Sebastien Bacher 2006-04-09 12:28:56 UTC 
bug submitter comment:

"Thanks for forwarding. Please note that there is a missing 'l' in the patch sent upstream (...fiename...). This is corrected in the debdiff (although that may not belong upstream). My apologies for the error."
Comment 3 Vincent Untz 2006-04-15 10:47:27 UTC 
Created attachment 63559 [details] [review]
Updated patch without the typo
Comment 4 Ray Strode [halfline] 2006-04-18 22:09:46 UTC 
Thanks, committed:

2006-04-18  Ray Strode <rstrode@redhat.com>

        Validate that desktop file categories match those
        specified in the spec.  Patch from Emmet Hikory
        <emmet.hikory@gmail.com> and
        Vincent Untz <vuntz@gnome.org> (bug 3337786)

        * src/validate.c (validate_categories): new
        function to ensure that categories are known.