GNOME Bugzilla – Bug 337382
Toggle button in main window not accessible.
Last modified: 2008-02-11 19:35:57 UTC
Planner (v0.13) has four toggle buttons in a panel down the left side: Gantt Chart Tasks Resources Resource Usage These have labels visually beneath them. Unfortunately there is no accessibility relationship between them. When one of those toggle buttons has focus, it doesn't know that the label beneath it is associated with it. Planner should use the LABEL_FOR relationship to match up each toggle button with the appropriate label.
Created attachment 96708 [details] [review] patch for src/planner-sidebar.diff
Javier - if I recall, you were interested in planner accessibility at one time. Can you try this patch and see if it resolves the problem?
This patch works fine for me on latest planner svn trunk. Except with the toolbar the ribbon toggle button to display more options, that can be found in other apps also. Would be nice to fix that in default but seems that there is no way to determine that we are on a ribbon toggle button. Now with this fixed I think that we can retire planner's script until new accessibility bugs requires it.
I tested this patch as well and it fixes the problem. Note that if this patch is checked in, we need to adjust the Orca planner.py script since this patch will break the workaround we have in planner.py to address this bug.
Planner maintainers: there is a patch attached to this bug that reported fixes the problem. Can it please be checked into SVN trunk and this bug closed? Thanks.
Created attachment 104833 [details] [review] Alternative accessibility patch I'd like to suggest this alternative, as it does not modify the appearance of the sidebar buttons. Please check if this patch also solves the problem. Is there an easy way I can check accessibility relations like this myself in a running GUI (a tool like spy++ for gtk+ maybe)?
You can test patches like this by running Orca and navigating the area in question via the keyboard. Orca should hopefully speak what is required. I'll try out your patch tomorrow. Thanks.
Created attachment 104964 [details] Orca debug output whilst testing this problem. I've just tried the version of planner that's in SVN trunk, and the accessibility problem no present. This is without applying either of the attached patches. So I presume the UI has been redesigned since I originally filed this bug in April 2006, and it's now correctly accessible. Closing as FIXED.
Actually I'll close it as OBSOLETE.
Are you sure it's not the work-around in planner.py mentioned by Willie in comment #4? This particular file has not been modified since October 2005, so the only way it can work now is because of changes outside Planner (gtk+, orca, ...).
Ahh, thanks Maurice. This is me trying to do too many things at the same time. Reopening so I can test your patch.
Okay, I think I have my act together now. First I applied the patch attached to bug #419136 to Orca from SVN trunk, to remove the workaround that's currently in the planner.py script. I then tried the second patch below to planner, and rebuilt and reinstalled. Orca now nicely speaks those four toggle buttons. I think this second patch can be committed. Thanks Maurice.
Ok, the patch was committed. Thanks for reporting & testing!