After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337358 - set about dialogue hooks
set about dialogue hooks
Status: RESOLVED FIXED
Product: libgnomeui
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal enhancement
: future
Assigned To: libgnomeui maintainers
libgnomeui maintainers
Depends on:
Blocks: 341070
 
 
Reported: 2006-04-05 12:58 UTC by Christian Persch
Modified: 2006-06-20 17:48 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
proposed patch (2.47 KB, patch)
2006-04-05 13:27 UTC, Christian Persch 		committed Details | Review

Description Christian Persch 2006-04-05 12:58:25 UTC 
GtkAboutDialog has 2 hook functions, to open links and email addresses. IMHO libgnomeui's GnomeProgram initialisation should implement those (using gnome_vfs_url_show), so not every program has to reinvent that.
Comment 1 Christian Persch 2006-04-05 13:27:28 UTC 
Created attachment 62790 [details] [review]
proposed patch
Comment 2 Christian Persch 2006-06-18 11:56:37 UTC 
Kjartan: any opinions on this patch? :)
Comment 3 Kjartan Maraas 2006-06-19 08:35:38 UTC 
Looks sane to me. Please commit if you've tested this. Maybe we should tell people about this before they go implementing the functions in their apps too?
Comment 4 Christian Persch 2006-06-20 17:48:32 UTC 
2006-06-20  Christian Persch  <chpe@cvs.gnome.org>

        * libgnomeui/gnome-ui-init.c: (show_url), (about_url_hook),
        (about_email_hook), (libgnomeui_private_free),
        (libgnomeui_get_property), (libgnomeui_set_property),
        (libgnomeui_class_init), (libgnomeui_post_args_parse),
        (libgnomeui_arg_callback): Set about dialogue hooks. Fixes bug
        #337358.

We have a GnomeGoal for this, http://live.gnome.org/GnomeGoals/AboutDialog and I'll make sure it's clear hat you don't need to implement those hooks yourself :)