After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337306 - Add a GtkMessageDialog::image property
Add a GtkMessageDialog::image property
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-04-05 05:01 UTC by Alex Graveley
Modified: 2011-02-04 16:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for discussion (7.63 KB, patch)
2006-05-01 21:49 UTC, Christian Persch 		none Details | Review

Description Alex Graveley 2006-04-05 05:01:54 UTC 
Message dialogs are currently limiting the image that can be displayed to gtk-info, gtk-warning, gtk-error stock IDs.  It is often useful to use a different dialog image.  

Adding a GtkMessageDialog::image property could allow setting the image contents to whatever the application wishes.

NOTE: Currently gtk_message_dialog_get_message_type (the accessor for the "message-type" property) expects the image stock ID to be one of the above, and asserts not implemented otherwise.  This should be changed to use the GtkMessageType passed to the constructor.
Comment 1 Christian Persch 2006-05-01 21:49:37 UTC 
Created attachment 64641 [details] [review]
patch for discussion

How about this?

I didn't want to add too much code, so I made only one property which can accept both a stock ID or an icon name.
Comment 2 Alex Graveley 2006-05-02 05:53:04 UTC 
This looks great to me.  In the future it might be nice to have access to the GtkImage widget itself, for things like animations.
Comment 3 Matthias Clasen 2006-05-09 04:34:49 UTC 
2006-05-09  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtk.symbols:
	* gtk/gtkmessagedialog.[hc]: Add an image property.  (#337306, Alex Graveley)