GNOME Bugzilla – Bug 337103
small cleanup in gstplugin.c
Last modified: 2006-04-04 17:59:02 UTC
I was taking a look at the file and noticed that the licenses list should be constified. I also noticed that there is a parent_class variable, but G_DEFINE_TYPE already takes care of defining and initializing a gst_plugin_parent_class variable. Note that the 'canonical' gobject way to init the parent class is g_type_class_peek_parent, which G_DEFINE_TYPE uses. gstplugin instead used g_type_class_ref, I have no idea if there is a rationale for using that or if instead all the uses in gstreamer should be changed...
Created attachment 62703 [details] [review] patch
Committed, thanks! I don't think there was a particular reason for the g_type_class_ref(), it was probably just a copy'n'paste from bad (old) boilerplate code from somewhere else. There are lots of those refs in GStreamer code. 2006-04-04 Tim-Philipp Müller <tim at centricular dot net> Patch by: Paolo Borelli <pborelli at katamail dot com> * gst/gstplugin.c: (gst_plugin_finalize), (gst_plugin_class_init), (gst_plugin_check_license): minor clean-up: G_DEFINE_TYPE already takes care of the parent_class stuff, no need to do it twice. Mark array of license strings as constant. (#337103)