After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 337068 - Use AS_HELP_STRING to format help messages
Use AS_HELP_STRING to format help messages
Status: RESOLVED FIXED
Product: libgtop
Classification: Core
Component: general
2.15.x
Other All
: Normal trivial
: ---
Assigned To: libgtop maintainers
libgtop maintainers
Depends on:
Blocks:
 
 
Reported: 2006-04-03 18:42 UTC by Julio Merino
Modified: 2006-12-01 18:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (3.84 KB, patch)
2006-04-03 18:43 UTC, Julio Merino 		committed Details | Review

Description Julio Merino 2006-04-03 18:42:51 UTC 
The configure script should use the AS_HELP_STRING macro to format the help messages attached to command line options.  This macro formats the messsages so that they appear properly aligned in the './configure --help' output, no matter the distance between the option name and its explanation.  Furthermore, if the explanation is longer than a line, this macro properly cuts it so that it is split in multiple lines.

The attached patch makes the configure code use this macro and also fixes the [] characters that should appear around the default values by using the appropriate quadrigraphs.
Comment 1 Julio Merino 2006-04-03 18:43:18 UTC 
Created attachment 62685 [details] [review]
Proposed patch.
Comment 2 Benoît Dejean 2006-04-04 06:00:07 UTC 
don't forget to add a changelog entry
Comment 3 Julio Merino 2006-04-04 06:08:19 UTC 
The attached patch does have a changelog entry.

By the way... if the "accepted-commit_now" status means that I should commit the patch myself... well, I can't.  I do not have cvs write access, so someone else will have to do it ;)
Comment 4 Benoît Dejean 2006-04-04 17:06:31 UTC 
ok then, i'll review all your great patch this weekend. Great job !
Comment 5 Julio Merino 2006-04-04 17:40:01 UTC 
Thanks :-)
Comment 6 Benoît Dejean 2006-12-01 18:48:48 UTC 
Fixed in CVS. The fix will go into the next patch release. Thank you for your bug report.