After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336956 - password protected rar files aren't detected
password protected rar files aren't detected
Status: RESOLVED DUPLICATE of bug 160538
Product: file-roller
Classification: Applications
Component: general
unspecified
Other All
: Normal minor
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2006-04-02 19:40 UTC by Sven Rech
Modified: 2006-04-02 20:03 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sven Rech 2006-04-02 19:40:48 UTC
Please describe the problem:
If you want to unrar a file with file-roller, this program isn`t able to realize
that the files are password protected, and so it shows an error message.

It's just a very small problem, but it can be very confusing for users who
aren't familiar with file-roller (I've read in a forum that someone thought
file-roller to be broken because of this. He booted Windows because of this...)

Steps to reproduce:
1. Open a password protected rar file
2. try to extract

Actual results:
You get a CRC error instead of a hint message

Expected results:


Does this happen every time?
yes

Other information:
I wrote a patch:

Index: fr-command-rar.c
===================================================================
RCS file: /cvs/gnome/file-roller/src/fr-command-rar.c,v
retrieving revision 1.23
diff -u -p -r1.23 fr-command-rar.c
--- fr-command-rar.c    9 Dec 2005 23:18:15 -0000       1.23
+++ fr-command-rar.c    2 Apr 2006 14:23:58 -0000
@@ -364,9 +364,13 @@ static void
 fr_command_rar_handle_error (FRCommand   *comm, 
                             FRProcError *error)
 {
-       if ((error->type == FR_PROC_ERROR_GENERIC) 
-           && (error->status <= 1))
-               error->type = FR_PROC_ERROR_NONE;
+       if (error->type == FR_PROC_ERROR_GENERIC)
+       {
+           if (error->status <= 1)
+                       error->type = FR_PROC_ERROR_NONE;
+               else if (error->status == 3)
+                       error->type = FR_PROC_ERROR_ASK_PASSWORD;
+       }
 }
Comment 1 Sergej Kotliar 2006-04-02 20:03:31 UTC
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.


*** This bug has been marked as a duplicate of 160538 ***