GNOME Bugzilla – Bug 336889
[avidemux] index creation might fail with some non-indexed AVI files
Last modified: 2006-04-20 16:38:23 UTC
Please describe the problem: If an AVI file does not have an index, it is created. The functions which create it, however, make the wrong assumption that data can only contain LIST and movi fourcc's. If an AVI file contains a LIST with a 'rec ' fourcc, garbage is read. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 62575 [details] [review] Patch fixing index creation
Thanks, committed: 2006-04-20 Tim-Philipp Müller <tim at centricular dot net> Patch by: Fabrizio Gennari <fabrizio dot ge at tiscali dot it> * gst/avi/gstavidemux.c: (gst_avi_demux_peek_tag), (gst_avi_demux_next_data_buffer), (gst_avi_demux_stream_scan): Fix index creation when we have to scan the file to create an index. There may be other types of RIFF 'LIST' chunks than 'movi' and we need to skip them properly as well or we'll end up reading garbage (#336889). Some other cosmetic changes. Sorry it took so long until someone got around to reviewing the patch.