After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336818 - volumes/drives in file chooser should be sorted
volumes/drives in file chooser should be sorted
Status: RESOLVED FIXED
Product: libgnomeui
Classification: Deprecated
Component: file-chooser
2.14.x
Other All
: Normal normal
: future
Assigned To: Christian Neumair
Federico Mena Quintero
Depends on: 147813
Blocks:
 
 
Reported: 2006-04-01 11:51 UTC by Christian Neumair
Modified: 2007-01-09 18:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.06 KB, patch)
2006-04-01 11:51 UTC, Christian Neumair 		committed Details | Review

Description Christian Neumair 2006-04-01 11:51:25 UTC 
gnome_vfs_volume_monitor_get_connected_drives() and gnome_vfs_volume_monitor_get_mounted_volumes() don't return sorted drives, these lists should be sorted using the (currently buggy, see bug 147813) GnomeVFS comparison functions.
Comment 1 Christian Neumair 2006-04-01 11:51:52 UTC 
Created attachment 62530 [details] [review]
Proposed patch
Comment 2 Kjartan Maraas 2006-12-09 13:20:29 UTC 
Federico, could you comment on this?
Comment 3 Federico Mena Quintero 2006-12-11 20:24:11 UTC 
The patch makes sense.  Thanks, Manny!

If this gives the same sorting order as Nautilus's Places sidebar, please go ahead and commit the patch to gnome-2-16 and HEAD.
Comment 4 Kjartan Maraas 2007-01-09 00:21:36 UTC 
Manny, feel free to commit if that is the case.
Comment 5 Federico Mena Quintero 2007-01-09 16:37:42 UTC 
Please go ahead and commit this.
Comment 6 Christian Neumair 2007-01-09 18:21:32 UTC 
Done, thanks.