After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336369 - Build broken under NetBSD
Build broken under NetBSD
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.14.x
Other NetBSD
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-28 16:34 UTC by Julio Merino
Modified: 2006-03-28 23:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch. (1.55 KB, patch)
2006-03-28 16:35 UTC, Julio Merino
none Details | Review

Description Julio Merino 2006-03-28 16:34:13 UTC
gdm does not build under NetBSD (3.99.16).  The daemon/gdmconfig.c and daemon/server.c files use the setpriority(2) function so, according to the manual page, they have to include sys/resource.h.  They currently do not include it.

The problem is that these files use PRIO_MAX, PRIO_MIN and PRIO_PROCESS definitions, all of which are only defined by the sys/resource.h header file in the NetBSD operating system.  The fix is trivial: include this header file in both files.

I have checked NetBSD, Solaris and Linux, and all three have sys/resource.h, so including it does not seem to be a portability problem.  In case you do not want to include it unconditionally, please DO NOT add a '#if defined(__NetBSD__)' to guard their inclusion.  Just tell me and I'll came up with an appropriate configure patch (if it's really needed).
Comment 1 Julio Merino 2006-03-28 16:35:27 UTC
Created attachment 62227 [details] [review]
Proposed patch.
Comment 2 Brian Cameron 2006-03-28 23:45:56 UTC
Thanks, fixed in CVS head.