GNOME Bugzilla – Bug 336350
Manual local cover art selection
Last modified: 2009-12-09 15:50:02 UTC
Banshee supports getting cover art from musicbrainz as well as using cover files stored in the album's folder itself. This is fine, but in various cases it would be nice to be able to manually pic the cover art. I propose to make the current cover art display area a drop target, so that you can drop image files there which are then stored in banshee's cover folder and used for that album. I half-way expected this to work because i knew this feature from muine... it would be a nice feature and it wouldn't even change the current interface. Why not just copy a cover.jpg to the library folder using nautilus? well: - manually locating the right folder is not always an easy task - some people (like me) don't have write permissions to the music store, so copying files to that directory is simply not possible. I have a large number of albums from garage bands that are not on musicbrainz, so this would be the only way to use the cover art feature for me. please consider Other information:
Thanks for the bug report. This is a feature request, and I would suggest adding to the wiki at http://www.banshee-project.org/FeatureRequest
Well... it's more a use case that is not covered by the current implementation, resulting in lower usability, so: bug ;)
Created attachment 80091 [details] [review] Allow manual cover art selection through d&d. This patch is an attempt to implement the feature request. It allows you to drop a cover image on the cover art view or cover art thumbnail to set the cover for an album/track. It works quite well, but is not totally done yet. One thing i'll add is a check for the filetype or mime-type. But I would like some comments on the patch. Is this the right way to do this?
You might want to have a look at the (currently disabled) cover art editor (it's in the metadata edit dialog, but not functional yet). Making that work would be awesome.
I'll consider that my next exercise. I still think this would make a nice addition to banshee though. It is really convenient and doesn't add any clutter to the interface.
One quick thing I see about this patch is that I will be deprecating the ASIN stuff altogether, so I wouldn't check for it. Always use TrackInfo.CreateArtistAlbumID and save the cover art appropriately. Cool stuff, I'll look at it more closely after 0.11.4.
Created attachment 80199 [details] [review] Allow manual cover art selection through d&d I've updated the patch. The ASIN stuff is out. I added a check for filetypes and saving files accordingly. The patch now partially depends on Trey Ethridge's patch: http://bugzilla.gnome.org/show_bug.cgi?id=388162 It still works without the patch but coverart other than .jpg isn't used.
This has been implemented hasn't it?
The patch still applies to trunk (not 100% clean but without errors) and changing coverart works, it's also saved correctly. But using this patch I lost my smart playlists... rebuild vanilla trunk and they showed up again. Just bad luck or a bug in the patch?
I just tried it against a fresh svn checkout and smart playlists still work fine here.
Yeah... I just noticed that smart playlists just don't show up sometimes, it'S not releated to the patch (looking at the patch I would really wonder where the two things could be connected ;) Can we get this into 0.12?
Looks good, can you provide us with a changelog entry?
Something like this? 2007-04-03 Pepijn van de Geer <pvandegeer@gmail.com> * src/Core/Banshee/PlayerInterface.cs: Set up CoverArtView and TackInfoHeader as a DropTarget and provide method to handle D&D for manual cover art selection. (BGO #336350) Should I normally add this to the patchfile? I think I read somewhere that I should, but it would instantly outdate the diff since the Changelog changes so often and the date would be out of date when te patch gets applied.
Perfect! Doesn't really matter where you supply it. You're right about the patch being outdated quickly if you embed it there, so pasting it in the bugzilla next to the patch is fine. Thanks Pepijn!
I'm a bit confused about this patch... doesn't the cover_art_view need to be visible for this to work? It's not visible if there's no cover art on the track, so I don't really get the point...
It also works on the small coverart icon in the TrackInfoHeader, which is always visible.
Did this ever get pulled in? I can't see what information is needed so I'm going to put this back to Open.
Please specify the latest version of banshee you have been able to test this against or let us know that this is no longer a problem. Thank you for helping us keep track of your bug.
Not fixed. Would be nice to have this both in the main interface (cover area) and track editor (as requested by aaron in a recent blog post.
Just committed a modified version of this to the stable branch, coming to trunk soon. Changes include: wrapping it all in a try/catch for safety and removing existing cover art (b/c even though we Copy with overwrite = true, that handle the case of different file types). Thanks everybody!
*** Bug 433109 has been marked as a duplicate of this bug. ***
*** Bug 541151 has been marked as a duplicate of this bug. ***
Is this still valid for trunk/1.0?
As you can read in #20, gabaug committed a modified patch to stable but the commit to trunk never happended, so 0.13.x has this feature while 1.0.x does not (yet).
Ah, I missed that, just read "committed". Wishful thinking. Reopening since the "stable" branch is now the legacy branch. :)
*** Bug 559919 has been marked as a duplicate of this bug. ***
If anybody wants to work on this, the way to do it in trunk is to modify the TrackInfoDisplay class to handle the DnD and, ideally, right click -> "Edit Cover Art" or something. Would probably be good to have a new tab in the Edit Track dialog for Cover Art that lets you choose/DnD a local file or select between the images found by the various Metadata providers (Last.fm, Rhapsody, etc) etc. Aaron's made it easy to add tabs to the editor through an extension point.
Created attachment 122790 [details] [review] Make TrackInfoDisplay accept drag and drop Here's a first step : with this patch, TrackInfoDisplay accepts and saves a cover art file dropped into it. TODO : 1. All the resized files of the pre-existing cover art should be deleted 2. Check that the file being dragged is an image 3. The UI stuff mentioned by Gabriel Feel free to work on that !
*** Bug 561096 has been marked as a duplicate of this bug. ***
I've been working on adding a new tab on the Edit Track Dialog for this purpose. (In reply to comment #27) > If anybody wants to work on this, the way to do it in trunk is to modify the > TrackInfoDisplay class to handle the DnD and, ideally, right click -> "Edit > Cover Art" or something. Would probably be good to have a new tab in the Edit > Track dialog for Cover Art that lets you choose/DnD a local file or select > between the images found by the various Metadata providers (Last.fm, Rhapsody, > etc) etc. Aaron's made it easy to add tabs to the editor through an extension > point. > I'd like to work on this if it's still open.
Scott, please go ahead, I don't think anybody else is working on the tab stuff.
(In reply to comment #31) > Scott, please go ahead, I don't think anybody else is working on the tab stuff. > Alright, is it easier on you guys to make it an extension or just put it in the actual source?
Not sure - I like the idea of putting it in the existing Banshee.CoverArt extension (and eventually moving the Last.fm/Amazon/etc downloaders there too).
Ok I'll work on putting it into the existing Banshee.CoverArt extension.
Created attachment 138822 [details] [review] Cover art tab Since this is a feature I was missing myself I spent the afternoon writing a small patch. It adds a cover art tab to the track editor dialog where you add, edit or remove the album art cover. The patch does not allow a lot of interaction such as DnD but simply uses 3 buttons to allow these operations. Also note that when removing the cover art and saving Banshee attempts to fetch the cover art automatically and, if found, instantly re-adds the cover art.
Created attachment 138823 [details] Screenshot demonstrating the cover art tab
Created attachment 138892 [details] [review] Code cleanup. Some code cleanup.
Created attachment 139102 [details] [review] Applied guidelines, using Banshee.IO. Small cleanup using Banshee.IO.
Thanks Jensen, this is a really good patch. Only nitpick is Catalog.GetString("Cover Art"); => Catalog.GetString ("Cover Art"); I'm setting this bug and patch as blocked by bug #583130, since it doesn't account for the crazy caching going on currently.
I just committed a different approach (making the existing cover art images editable via DnD and context menu) to the art-caching branch, which should be merged into master soon: http://git.gnome.org/cgit/banshee/log/?h=art-caching
Merged to master; fixed.
Drag and drop of a picture from a web browser (tested in Firefox) doesn't work yet. Would be very nice as it would obsolete the steps "save to directory", "browse to folder and select picture", "delete file again in file browser".
(In reply to comment #42) > Drag and drop of a picture from a web browser (tested in Firefox) doesn't work > yet. Would be very nice as it would obsolete the steps "save to directory", > "browse to folder and select picture", "delete file again in file browser". I noticed this too (with Chrome - good to know the same is true of Firefox), and I opened Bug 603911 to track the issue.