GNOME Bugzilla – Bug 336019
Staged installs possibly broken if overriding sysconfdir
Last modified: 2006-05-20 12:36:11 UTC
The patch I sent in bug 134517 possibly broke staged installs if the user overrides sysconfdir from the command line. E.g.: make install sysconfdir=/some/directory The problem is that sysgconfdir is assigned with double quotes, which leads to the expansion of the sysconfdir variable. This must not happen within the configure script, as the Automake documentation says; otherwise, the variables cannot be properly overriden from the command line. In order to fix this issue, the variable has to be assigned with single quotes and sysconfsubdir must be exported to Makefiles so that they can fetch is value during expansion. I said that this possibly breaks installation because a similar patch did it for gnopernicus (see bug 324283). I'm not sure though because it is strange that nobody has complained about it yet. But anyway, the problem is real as the above command will not work with the current code.
Created attachment 62013 [details] [review] Fix for the mentioned issue.
Looks good, please commit to HEAD
Sorry, I do not have commit privileges.
Commited. Thanks.
The change to using single quotes does not allow for variable substitution and will cause gconf/2/path to contain entries like: xml:readonly:${prefix}/etc/gonc/gconf.xml.mandatory
Created attachment 65328 [details] [review] Fixes for default.path.in. This patch should fix the issues reported in the last comment; at least it does for me. Could you please try it? Thanks.
I applied this patch to both branches since gconf was really broken without it. Now all is well in the land of CVS again. Thanks a lot.