GNOME Bugzilla – Bug 335562
Obsolete (and maybe dangerous) code in gnome-doc-utils.m4
Last modified: 2006-05-29 13:33:03 UTC
Please describe the problem: While configuring gdu 0.6.0 on my machine I saw a spurious 'gnome-config: not found' line during the generation of the output files. That was a symptom of pkg-config being called in an unexpected place. Unexpected because once configure is generating output files it should not check for anything. It also raised my attention because pkg-config's log file told me that gdu was checking for gdu itself, which was strange (a program checking for itself?). Upon further inspection, I found a piece of code in gnome-doc-utils.m4 that makes me dubious. It is the AC_OUTPUT_COMMANDS macro used at the very end. I cannot understand why it is needed: configure should not touch any of the "source" files used to generate output files. It is up to the developer to do that or not. Why? If configure decides to update a local file with one that is already installed (as the code attempts to do with $gdumk), it can break the program being built. Just consider what would happen if the new mk file is incompatible with the one distributed with the package. In other words: the developer is the one who has to decide when to update its package to a newer version of gdu by using the gnome-doc-prepare script. (Just check what, e.g., libtoolize or gtkdocize do.) Also, the warning that says that gnome-doc-utils.make should be added to the EXTRA_DIST is useless, I think. If a developer has this file in a package, it is because he 'include's it from a Makefile.am, isn't it? If so, automake automatically adds the file to EXTRA_DIST. Not to mention that the file oughtn't be in the build directory but simply stay in $(srcdir) or $(top_srcdir). See automake.info, section Include. Summarizing: it seems to me that the whole AC_OUTPUT_COMMANDS call that is currently in gnome-doc-utils.m4 has to go away. Note: I mailed this same text to gnome-doc-utils author asking whether I was right or not. As I got no response, I am filing a bug report so that the issue is not lost. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 61787 [details] [review] Sample patch.
I reported the same problem too. I will merge your report with #331735. *** This bug has been marked as a duplicate of 331735 ***