GNOME Bugzilla – Bug 334920
register cell with very little cell padding
Last modified: 2018-06-29 21:00:00 UTC
As already noted on IRC: When comparing 1.8.x and SVN, my wife complains about the reduced cell padding in the register. The attached screenshots show the register in 1.8.x, where there is a padding from the text baseline to the bottom border of the cell of in total 5 pixels. With this 5 pixels of padding, even below the ',' (comma, the German decimal separator) there is still 3 pixels of cell padding, and below the 'g' character still 2 pixels of padding. The second screenshot shows the register in current SVN (which now has an anti-aliased font), where the padding from the text baseline of the normal (unselected) text to the bottom border of the cell is only 2 pixels. The letter 'g' therefore hits the botton border, as well as the comma ',' character. In the third screenshot the number column is also selected, and in that case the base line of the selected text has only *one* pixel of padding left. The comma character looks pretty weird. Well, all in all the gnome2/SVN text in the bottom line of the register looks much more crammed to the bottom border. I don't care much, but my wife complains *every* time :-))
Created attachment 61457 [details] The bottom line of the register window in 1.8.x gnucash.
Created attachment 61458 [details] The bottom line of the register window in gnome2/SVN gnucash
Created attachment 61459 [details] The bottom line of the register window in gnome2/SVN gnucash with selected text
Oh, I forgot my suggestion: The register cells should get 1, 2 or 3 pixels of extra padding at the bottom. The 1.8.x behaviour at this point obviously had 3 pixels of extra padding compared to the current SVN status. As for top, left, and right: The 1.8.x picture has 5 pixels of padding between the 'E' character and the top border; the SVN picture has 4 pixels of padding there. This can probably be left as-is, or one pixel might be added. I can't check the padding to the left, but the padding to the right of the '7' number is 5 pixels in both 1.8.x and SVN, so that can be left as-is as well. If we can't decide on the "nicest" bottom padding right now, we could also make this a preference, although this would be precisely that kind of preference that shouldn't be there in the first place...
r13692 makes a first step. Lets see what your wife and the rest of the bleeding edge part of the GnuCash community says about it.
Thanks for implementing this. My wife is now much happier with the register look :-) So from my point of view, we can leave it with your changed implementation.
I am sorry, can you please do me a favor and play with src/register/register-gnome/gnucash-sheet.h CELL_{VH}PADDING? The more I think/look about/at it, the more I feel like reducing VPADDING to 2 would be better. HPADDING does not really make that much of a difference to me :) If you do feel the same and the waf (womans acceptance factor) is high enough, feel free to commit the change and close.
For my wife a VPADDING=2 looks fine. For myself, both are fine. I think we should stick with your proposed VPADDING=2. Committed as r13703. (I am still not yet happy with the black lines in the register and would probably prefer the register without that, but that's another issue that doesn't belong to this bug...)
[OT] Christian, BTW, you can remove the black lines by unchecking "Draw {horiz,vertical} lines between cells" in the register preferences.
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=334920. Please update any external references or bookmarks.