GNOME Bugzilla – Bug 334620
[gnomevfssrc] fails to connect to icecast streaming servers
Last modified: 2006-03-15 17:13:08 UTC
Please describe the problem: When gnomevfssrc connects to some streaming server, it first pushes the HTTP callbacks. However, this first open attempt fails because it tries to use pull- mode, that does not work in this case. Then HTTP callbacks are pop'ped, but the "http_callbacks_pushed" flag is not set to FALSE. When the connection is established second time (push-mode), this callback pushing won't happen again because of the flag is still TRUE. I will attach a trivial patch that fixes this. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 61268 [details] [review] Patch that fixes HTTP callback pushing problem
Interesting, I wonder if this was the real cause of bug #331690 ... (FWIW, with gst-plugins-base 0.10.5 gnomevfssrc shouldn't try to open in pull mode any longer if the URI is a http URI, but I suppose this should be fixed regardless).
Committed, thanks for the patch! 2006-03-15 Tim-Philipp Müller <tim at centricular dot net> Patch by: Tommi Myöhänen <ext-tommi dot myohanen at nokia dot com> * ext/gnomevfs/gstgnomevfssrc.c: (gst_gnome_vfs_src_pop_callbacks): Don't forget to set src->callbacks_pushed to FALSE again when popping them, otherwise re-activation in a different mode won't work (#334620).