GNOME Bugzilla – Bug 334551
Rhythmbox can't compile DAAP support
Last modified: 2006-03-19 08:38:04 UTC
Please describe the problem: I have avahi 0.5.2, and I've tried to build rhythmbox with --enable-daap, but it fails with gcc -DHAVE_CONFIG_H -I. -I. -I.. -DGNOMELOCALEDIR=\"/usr/local/share/locale\" -DG_LOG_DOMAIN=\"Rhythmbox\" -I.. -I../lib -I../lib -I../corba -I../corba -I../rhythmdb -I../library -I../iradio -I../widgets -I../shell -I../sources -DPIXMAP_DIR=\"/usr/local/share/pixmaps\" -DSHARE_DIR=\"/usr/local/share/rhythmbox\" -DDATADIR=\"/usr/local/share\" -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/libbonoboui-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/gnome-keyring-1 -I/usr/include/orbit-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/freetype2 -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/include/gnome-vfs-module-2.0 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -pthread -DORBIT2=1 -I/usr/include/gstreamer-0.8 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/libsoup-2.2 -I/usr/include/libxml2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -D_REENTRANT -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -O2 -pipe -Wcomment -Wformat -Wnonnull -Wimplicit-int -Wimplicit -Wmain -Wmissing-braces -Wparentheses -Wsequence-point -Wreturn-type -Wswitch -Wtrigraphs -Wunused-function -Wunused-label -Wunused-value -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wall -Werror -std=gnu89 -MT rb-daap-mdns-publisher-avahi.lo -MD -MP -MF .deps/rb-daap-mdns-publisher-avahi.Tpo -c rb-daap-mdns-publisher-avahi.c -fPIC -DPIC -o .libs/rb-daap-mdns-publisher-avahi.o rb-daap-mdns-publisher-avahi.c: In function 'client_cb': rb-daap-mdns-publisher-avahi.c:116: error: 'AVAHI_CLIENT_FAILURE' undeclared (first use in this function) rb-daap-mdns-publisher-avahi.c:116: error: (Each undeclared identifier is reported only once rb-daap-mdns-publisher-avahi.c:116: error: for each function it appears in.) rb-daap-mdns-publisher-avahi.c:120: error: 'AVAHI_CLIENT_CONNECTING' undeclared (first use in this function) cc1: warnings being treated as errors rb-daap-mdns-publisher-avahi.c: In function 'avahi_client_init': rb-daap-mdns-publisher-avahi.c:144: warning: passing argument 2 of 'avahi_client_new' from incompatible pointer type Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information: I do have the corresponding -dev files for rhythmbox. 0.9.3.1 builds fine.
Created attachment 61426 [details] [review] probably fixes it I haven't tested this, but it should fix the compile errors you're seeing.
That makes it go a lttle further, but not quite. I'd updated today, and then tried your patch, which failed. I manually merged it, and this is what I get: gcc -DHAVE_CONFIG_H -I. -I. -I.. -DGNOMELOCALEDIR=\"/usr/local/share/locale\" -DG_LOG_DOMAIN=\"Rhythmbox\" -I.. -I../lib -I../lib -I../corba -I../corba -I../rhythmdb -I../library -I../iradio -I../widgets -I../shell -I../sources -DPIXMAP_DIR=\"/usr/local/share/pixmaps\" -DSHARE_DIR=\"/usr/local/share/rhythmbox\" -DDATADIR=\"/usr/local/share\" -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/libbonoboui-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/gnome-keyring-1 -I/usr/include/orbit-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/freetype2 -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/include/gnome-vfs-module-2.0 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -pthread -DORBIT2=1 -I/usr/include/gstreamer-0.8 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/libsoup-2.2 -I/usr/include/libxml2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -D_REENTRANT -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -O2 -pipe -Wcomment -Wformat -Wnonnull -Wimplicit-int -Wimplicit -Wmain -Wmissing-braces -Wparentheses -Wsequence-point -Wreturn-type -Wswitch -Wtrigraphs -Wunused-function -Wunused-label -Wunused-value -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wall -Werror -std=gnu89 -MT rb-daap-mdns-browser-avahi.lo -MD -MP -MF .deps/rb-daap-mdns-browser-avahi.Tpo -c rb-daap-mdns-browser-avahi.c -fPIC -DPIC -o .libs/rb-daap-mdns-browser-avahi.o rb-daap-mdns-browser-avahi.c: In function 'client_cb': rb-daap-mdns-browser-avahi.c:95: error: 'AVAHI_CLIENT_FAILURE' undeclared (first use in this function) rb-daap-mdns-browser-avahi.c:95: error: (Each undeclared identifier is reported only once rb-daap-mdns-browser-avahi.c:95: error: for each function it appears in.) rb-daap-mdns-browser-avahi.c: In function 'resolve_cb': rb-daap-mdns-browser-avahi.c:156: error: 'AVAHI_ADDRESS_STR_MAX' undeclared (first use in this function) cc1: warnings being treated as errors rb-daap-mdns-browser-avahi.c:156: warning: unused variable 'host' rb-daap-mdns-browser-avahi.c: In function 'browse_cb': rb-daap-mdns-browser-avahi.c:266: warning: implicit declaration of function 'get_avahi_client' rb-daap-mdns-browser-avahi.c:266: warning: nested extern declaration of 'get_avahi_client' rb-daap-mdns-browser-avahi.c:266: warning: passing argument 1 of 'avahi_client_is_service_local' makes pointer from integer without a cast make[1]: *** [rb-daap-mdns-browser-avahi.lo] Error 1 make[1]: Leaving directory `/home/adam/rhythmbox/daapsharing' make: *** [all] Error 2 From the CVS of 2006-03-17
Created attachment 61474 [details] [review] updated patch This includes the changes from the previous patch too, so you might have to revert that one before this will apply.
The second patch works.
Committed. Thanks for your help with this, Adam.