GNOME Bugzilla – Bug 334137
misc libwnck fixes
Last modified: 2006-03-25 08:52:07 UTC
Here are two leak fixes in tasklist.c and a branch-result-depends-on- uninitialized-memory fix for xutils.c. (The specific problem is that icon_cache->prev_mask doesn't get initialized, but really, if God had meant for us to initialize variables to 0 one-by-one, he wouldn't have given us g_new0.)
Created attachment 61039 [details] [review] patch
Sweet, thanks for catching this. Is this causing any big issues, or should we just wait until after 2.14.0 to avoid the need to get approval to break hard code freeze? Also, for future reference, could you use the -p flag when creating patches to make it easier for me to read them? Thanks.
The downstream bug is https://bugzilla.novell.com/show_bug.cgi?id=78329. (His comment that he's only using the Window Selector is probably mistaken; the other three all run on the bottom panel by default and he probably didn't realize that counted as part of the panel too.) He's seeing a huge leak. I'm not sure that the leaks I fixed are large enough to be the source of his problems, and I haven't heard back from him yet on whether or not my patch fixes it for him. So there may be further patches. At any rate, it's an old problem, so probably not freeze-break-worthy. (The uninitialized variable part doesn't cause any problems that I'm aware of, it's just something valgrind pointed out while I was searching for the leaks.)