After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333683 - [id3mux] patch to add support for GST_TAG_ALBUM_VOLUME_NUMBER
[id3mux] patch to add support for GST_TAG_ALBUM_VOLUME_NUMBER
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other All
: Normal normal
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-07 01:56 UTC by Alex Lancaster
Modified: 2006-03-07 11:20 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
Support for element (685 bytes, patch)
2006-03-07 01:57 UTC, Alex Lancaster 		committed Details | Review

Description Alex Lancaster 2006-03-07 01:56:31 UTC 
Please describe the problem:
id3demux reads the GST_TAG_ALBUM_VOLUME_NUMBER but id3mux does not write it. 
This patch adds support for this tag.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Alex Lancaster 2006-03-07 01:57:08 UTC 
Created attachment 60812 [details] [review]
Support for element
Comment 2 Alex Lancaster 2006-03-07 02:04:33 UTC 
You can see that such support is missing if you run the plugin in the debug mode, by prepending the environment variable:

GST_DEBUG=id3tag:5

WARN  (0x8972f40 - 0:00:09.807873000)               id3tag(28088) gstid3tag.c(820):tag_list_to_id3_tag_foreach: unhandled GStreamer tag album-disc-number
Comment 3 Tim-Philipp Müller 2006-03-07 11:20:26 UTC 
Committed, thanks for the patch!

2006-03-07  Tim-Philipp Müller  <tim at centricular dot net>

       * ext/mad/gstid3tag.c: (tag_list_to_id3_tag_foreach):
         Add support for writing the GST_TAG_ALBUM_VOLUME_NUMBER
         tag (#333683, patch by: Alex Lancaster).