After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333653 - the keyring daemon should be able to have it's display env set by a client
the keyring daemon should be able to have it's display env set by a client
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-03-06 20:08 UTC by Jon Nettleton
Modified: 2006-06-04 18:28 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
allows the display ENV of the daemon to be updated (3.26 KB, patch)
2006-03-06 20:43 UTC, Jon Nettleton 		none Details | Review

Description Jon Nettleton 2006-03-06 20:08:37 UTC 
the keyring daemon can launch and run without have a display to output to.  I
see no reason why a client app that wants to use the daemon shouldn't be able to
update the display evironment variable for the daemon.  The functional use case
can be seen in gnome-session.  Gnome-session checks to see if the
GNOME_KEYRING_SOCKET is set and is writable and then returns.  If it is going to
use that daemon it should also update DISPLAY for that daemon so user
interaction works properly.
Comment 1 Jon Nettleton 2006-03-06 20:43:54 UTC 
Created attachment 60796 [details] [review]
allows the display ENV of the daemon to be updated
Comment 2 Jon Nettleton 2006-03-08 15:24:29 UTC 
I filed this bug, http://bugzilla.gnome.org/show_bug.cgi?id=333901 as a patch for gnome-session if this change is accepted.  These changes provide the needed infrastructure to implement a solution like, http://bugzilla.gnome.org/show_bug.cgi?id=312877 and have gnome-keyring-daemon still function properly.
Comment 3 Alexander Larsson 2006-04-19 14:05:13 UTC 
This is a security issue. Anyone could set the display to somewhere and circumvent the dialogs to the user. I changed the code so that you can only set the display if it wasn't already set and commited. Thats good enough, isn't it?
Comment 4 Jon Nettleton 2006-04-19 14:41:12 UTC 
That should be fine thanks.
Comment 5 Fernando Herrera 2006-06-04 18:28:27 UTC 
So closing this bug