GNOME Bugzilla – Bug 333020
Ctrl-G does not pop up find bar
Last modified: 2006-05-11 14:25:05 UTC
Hitting ctrl-g to search for the next match does not pop up the find bar. I can't think of a valid reason why it should remain hidden. It this intended behaviour?
Agreed.
Should the toolbar entry get focus again if you hit ctrl-g?
Created attachment 64426 [details] [review] Proposed fix This patch will make the find toolbar reappear for find next/previous. This happens then the user: - presses ctrl-g - presses ctrl-shift-g - chooses Edit->Find Next - chooses Edit->Find Previous Note that I explicitly set focus to the toolbar entry again. While this may seem odd at first sight, it feels really good. "Find" (without next/previous) sets the focus, why shouldn't find next/previous? (Added bonus: you can refine your search directly by typing a new query string.) Please try the patch before complaining about the focus.
Btw, this patch also fixes another usability bug: refining your search keyword (eg. fixing a typo) was only possible as long as you kept the toolbar open. Once it was gone (eg. because of a click) you couldn't refine your keyword and had to add them all over again. With this patch applied, this gap is filled. :)
Created attachment 64935 [details] [review] Improved patch This improved patch only focuses the find entry if the find toolbar was previously not visible. This fixes the following problem my previous patch introduced: 1. Type / to start finding 2. The find bar pops up 3. Type some letters, eg. "to" 4. See the page scroll to the next match 5. Press Ctrl-G. 6. Do it again. 7. And again. 8. Again, if you like... ;) 9. Type some more letters, eg. "tal" (to search for "total") Old patch: 10. Yuck, when ctrl-g was pressed the current terms were selected (caused by the focus grab) New patch: 10. Yay, we're searching for "total"!
That's better, yeah.
2006-05-11 Wouter Bolsterlee <uws+gnome@xs4all.nl> * src/ephy-find-toolbar.c: (ephy_find_toolbar_find_next), (ephy_find_toolbar_find_previous), (ephy_find_toolbar_open): Display the find bar for "Find Next" and "Find Previous" if it wasn't visible already. Entry focus is handlded with care so that use cases like incremental search work as expected. Fixes bug #333020.