Confirming. The contact editor, photo selection file selector has a button No Image. It misses a mnemonic. Proposing (_N)

Created attachment 60380 [details] [review]
Patch for the missing mnemonic

the patch is not correct, it includes another changelog entry for bug 330353 and some empty lines which shouldn't be there.

Comment on attachment 60380 [details] [review]
Patch for the missing mnemonic

>Index: e-contact-editor.c
>===================================================================
>RCS file: /cvs/gnome/evolution/addressbook/gui/contact-editor/e-contact-editor.c,v
>retrieving revision 1.251
>diff -u -p -r1.251 e-contact-editor.c
>--- e-contact-editor.c	1 Feb 2006 11:07:17 -0000	1.251
>+++ e-contact-editor.c	1 Mar 2006 08:38:37 -0000
>@@ -2755,7 +2755,7 @@ static void
> image_clicked (GtkWidget *button, EContactEditor *editor)
> {
> 	const gchar *title = _("Please select an image for this contact");
>-	const gchar *no_image = _("No image");
>+	const gchar *no_image = _(" _No image");
> 	GtkImage *preview;
> 
> 	if (!editor->file_selector) {
>Index: ChangeLog
>===================================================================
>RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
>retrieving revision 1.3801
>diff -u -p -r1.3801 ChangeLog
>--- ChangeLog	13 Feb 2006 14:36:11 -0000	1.3801
>+++ ChangeLog	1 Mar 2006 08:50:29 -0000
>@@ -1,3 +1,17 @@
>
>
>+2006-02-28  Poornima C  <poory85@hotmail.com>
>+	** Fixes bug #332963.
>+     
>+        * e-calender-contact-editor.c
>+        Added accelerator key for the label of button 'No image' in adding a picture
>+        for contacts.
>+
>+2006-02-25  Poornima C	<poory85@hotmail.com>
>+        ** Fixes bug #330353.
>+
>+        * em-folder-view.c:(hide_deleted)
>+        Removed the Delete label from the popup of rightclick on the message which is 
>+        already deleted.
>+
> 2006-02-13  Karsten Br�ckelmann  <guenther@rudersport.de>
>  
> 	* em-account-editor.c: Fix the Account Editor / Security option to
>@@ -11045,4 +11059,11 @@
> 	order; don't replace the label of the stock Find button.  Also,
> 	add Escape as a keybinding for the Close button (see why GTK+ is
> 	on crack on b.g.o #74221 and #101293).
>+
>+
>+
>+	
>+	
>+
>+         
>

?

poornima, please attach patches as attachments and not as an inline quote.
also, please use the correct changelog file (the addressbook one and not the mail one, since you want to patch the addressbook).
also, please have a clean changelog diff - your changelog diff also adds something about bug 330353 - this is not sufficient.

Created attachment 67161 [details] [review]
To set a mnemonic for " No image " label

i applied the patch, recompiled and tested it and it works fine.

patch committed to CVS HEAD:
http://cvs.gnome.org/viewcvs/evolution/addressbook/gui/contact-editor/e-contact-editor.c?r1=1.259&r2=1.260

fix will be included in evolution 2.7.4.

aishwarya: for future reference, please make sure that the whitespaces in your changelog entry is correct, means
                    * e-contact-editor.c: Set
instead of
                    *e-contact-editor.c :Set
and add an empty line at the end of your entry. thanks a lot!