GNOME Bugzilla – Bug 332169
Support libnotify 0.3.x API
Last modified: 2006-03-16 01:17:59 UTC
i get this errors: gossip-notify.c:48: error: syntax error before '*' token gossip-notify.c:51: error: syntax error before '*' token cc1: warnings being treated as errors gossip-notify.c:52: warning: type defaults to 'int' in declaration of 'notify_new_message' gossip-notify.c:52: warning: data definition has no type or storage class gossip-notify.c: In function 'gossip_notify_contact_online': gossip-notify.c:132: error: 'NotifyIcon' undeclared (first use in this function) gossip-notify.c:132: error: (Each undeclared identifier is reported only once gossip-notify.c:132: error: for each function it appears in.) gossip-notify.c:132: error: 'icon' undeclared (first use in this function) gossip-notify.c:133: error: 'NotifyHandle' undeclared (first use in this function) gossip-notify.c:133: error: 'handle' undeclared (first use in this function) ... It detect a version that it can compile agains using auto* magic and if not available just disable this feature.
Yea, this is a known problem. I built in support for libnotify 0.2.1 which is on Breezy. When I get the next build of Ubuntu in a few months I will fix this up. You can disable it with ./autogen.sh --disable-libnotify for the time being.
*** Bug 332578 has been marked as a duplicate of this bug. ***
Created attachment 60276 [details] [review] Initial 0.3.2 libnotify patch Martyn, here's what I've got so far for the 0.3.2 api changes. It still needs some work, in particular the 'notify_notification_add_action' calls which changed it api between 0.3.0 (what I'm on) and 0.3.2, so I haven't tested that it works. Hopefully, this will be of some help to you.
Created attachment 60278 [details] [review] Corrected Patch D'oh, noticed a error in my prior patch.
Thanks I will take a look soon.
Mmm, I couldn't patch Gossip with this patch, I get: martyn@betula:~/Gnome/source/gossip$ patch -p0 < notify.patch patching file src/gossip-notify.c patch: **** malformed patch at line 55: @@ -124,12 +133,13 @@ Can you recreate the patch using 'cvs diff -up > notify.patch'?
Created attachment 61303 [details] [review] New patch for libnotify Martyn, here's a new patch. If you have any problems, don't hestitate to contact me.
*** Bug 130229 has been marked as a duplicate of this bug. ***
I have committed your patch Brian with a few improvements ;) - mostly I just removed some of the old crap I put in there for pixbuf management with the 0.2.x API but apart from that - all good thanks! The only thing I couldn't see how to do was how to keep the notification up until the timeout on some actions. In the old code the "Contact Information" option should not hide the notification so the user could still click to "Respond". If you see how to do this, feel free to let me know/knock up a patch. Thanks again ;)