After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 332066 - [qtdemux] doesn't extract Disc Number field from some files
[qtdemux] doesn't extract Disc Number field from some files
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.x
Other Linux
: Normal normal
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-21 17:22 UTC by Loïc Minier
Modified: 2006-05-03 21:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
first sample (500.00 KB, application/octet-stream)
2006-03-08 11:36 UTC, Loïc Minier
Details
second m4a sample (500.00 KB, application/octet-stream)
2006-03-08 11:37 UTC, Loïc Minier
Details

Description Loïc Minier 2006-02-21 17:22:36 UTC
Hi,

Stephen Touset reported in Debian bug http://bugs.debian.org/347616 that the disc number is not detected correctly for AAC files.

This might be a GStreamer bug, but I have no idea whether Rhythmbox has to adapt its pipeline to see such information.

Cheers,
Comment 1 Alex Lancaster 2006-02-21 19:23:47 UTC
rhythmbox can read that metadata tag (disc number) if it is set (I just checked an ID3-tagged mp3) and it doesn't do anything special for different file types.  So it is also certainly caused by the gstreamer plugin not returning that information to rhythmbox.  Reassigning to gstreamer-plugins-bad.
Comment 2 Alex Lancaster 2006-02-21 20:20:37 UTC
One thing to check is whether that disc tag is set correctly inside your .m4a file.  Using faad (AAC decoder) you can do this like so (you should have the faad library installed if you can hear the music):

faad -i yourfile.m4a

Of course, it's possible that the faad application is broken in this respect too (and hence the gstreamer plugin that it is based on).
Comment 3 Tim-Philipp Müller 2006-02-21 20:59:05 UTC
If anyone has a sample file [*] that shows this problem, it would be much appreciated. Glancing at the code it looks like the tag should be picked up, but maybe it's using a different identifier than the code expects.

[*] only the first ~500kB or so are of interest really; you can dump the beginning into a file with 'head --bytes=500k foo.m4a > foo-header.m4a'

Comment 4 Tim-Philipp Müller 2006-03-06 23:35:57 UTC
Can't do anything about this without a sample.
Comment 5 Alex Lancaster 2006-03-07 02:02:44 UTC
I found that the id3mux tag writing element for mp3 files was missing support for GST_TAG_ALBUM_VOLUME_NUMBER, see bug #333683.  Could be that the AAC plugin is also missing similar functionality.  (The new tagid3v2mux also has the same problem: bug #333501).
Comment 6 Loïc Minier 2006-03-07 08:59:16 UTC
(Tim, I've sent a second request for an excerpt to the submitter.  I did send a request on 22 Feb 2006.)
Comment 7 Loïc Minier 2006-03-08 11:36:22 UTC
Created attachment 60904 [details]
first sample
Comment 8 Loïc Minier 2006-03-08 11:37:13 UTC
Created attachment 60905 [details]
second m4a sample
Comment 9 Tim-Philipp Müller 2006-03-08 12:17:17 UTC
Excellent, thanks for the samples. Should be fixed now:

2006-03-08  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/qtdemux/qtdemux.c: (qtdemux_parse_udta):
          Extract disc number and count from files that use
          'disk' instead of 'disc' as node identifier for that
          (fixes #332066).