After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 331994 - --disable-debug removes G_DISABLE_CAST_CHECKS
--disable-debug removes G_DISABLE_CAST_CHECKS
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
1.10.x
Other All
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2006-02-21 08:31 UTC by Arnaud Charlet
Modified: 2006-02-21 10:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Arnaud Charlet 2006-02-21 08:31:35 UTC 
Please describe the problem:
The configure option --disable-debug incorrectly removes the
-DG_DISABLE_CAST_CHECKS flag.

Here is the trivial patch that corrects this problem:

--- configure.in.old    2006-02-21 09:26:21.000000000 +0100
+++ configure.in        2006-02-21 09:26:46.000000000 +0100
@@ -167,7 +167,7 @@ else
   PANGO_DEBUG_FLAGS="-DG_DISABLE_CAST_CHECKS"

   if test "x$enable_debug" = "xno"; then
-    PANGO_DEBUG_FLAGS="$GLIB_DEBUG_FLAGS -DG_DISABLE_ASSERT -DG_DISABLE_CHECKS"

+    PANGO_DEBUG_FLAGS="$GLIB_DEBUG_FLAGS -DG_DISABLE_ASSERT -DG_DISABLE_CHECKS
$PANGO_DEBUG_FLAGS"
   fi
 fi

Steps to reproduce:
1. 
2. 
3. 

Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Behdad Esfahbod 2006-02-21 10:20:31 UTC 
Thanks.

2006-02-21  Behdad Esfahbod  <behdad@gnome.org>

        * pango/fonts.c, pango/glyphstring.c, pango/pango-fontmap.c,
        pango/pango-ot-buffer.c, pango/pangocairo-font.c, pango/pangoft2.c,
        pango/pangoxft-font.c, pango/shape.c: Change g_critical to g_warning.
        We already handle them gracefully.

        Bug 331994 – --disable-debug removes G_DISABLE_CAST_CHECKS
        Patch from charlet@act-europe.fr

        * configure.in: Do not lose PANGO_DEBUG_FLAGS when reassigning.

        Bug 331995 – pango_layout_set_text optimization
        Patch from charlet@act-europe.fr

        * pango/pango-layout.c: Do not validate input text if asserts are
        disabled.  Moreover, do not truncate input text on invalid sequence.

        Bug 331996 – avoid crashes in win32 font handling
        Patch from charlet@act-europe.fr

        * pango/pangofc-fontmap.c, pango/pangowin32-fontmap.c,
        pango/pangowin32.c: if (!font) return NULL in a number of places.